-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: mac render tests #9175
chore: mac render tests #9175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addresses one of the biggest inefficiences working with deck.gl, being that I have to rely on deck's CI during integration.
(Another issue is that deck's CI is quite slow relative to e.g. luma.gl etc and could stand to be optimized, but the urgency of that is significantly reduced by this change).
As minor nits:
- I would avoid capital case in file names. Either call toLowerCase on the OS constant, or update the constants to be lower case.
- I would add also string literal types to the OS constant.
let OS: 'mac' | 'windows' | 'unknown';
Additionally noting that it might be desirable to consolidate platform detection.
- We have platform detection in luma.gl's
device.info
that I have been using to disable some local tests when running under mac OS. - We have similar platform detection in probe.gl
Opportunity to enable TextLayer tests on CI? deck.gl/test/render/test-cases/text-layer.js Lines 47 to 49 in aa2537b
|
Good idea, but they need to be generated on Linux. Would you mind @Pessimistress ? |
Yes, it could be nice to move the override functionality into probe.gl as there we could check if the file existed prior to running the check |
Background
There are a number of tests that give slightly different results on mac. Currently this leads to the tests failing when run locally on mac, which makes it harder to develop. With this change all of the tests pass (Mac M3) when running
yarn test browser
Change List