Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mac render tests #9175

Merged
merged 5 commits into from
Sep 26, 2024
Merged

chore: mac render tests #9175

merged 5 commits into from
Sep 26, 2024

Conversation

felixpalmer
Copy link
Collaborator

Background

There are a number of tests that give slightly different results on mac. Currently this leads to the tests failing when run locally on mac, which makes it harder to develop. With this change all of the tests pass (Mac M3) when running yarn test browser

Change List

  • Provide mechanism to override golden images per platform
  • Add golden images for Mac

@coveralls
Copy link

coveralls commented Sep 23, 2024

Coverage Status

coverage: 91.738% (-0.001%) from 91.739%
when pulling 516ef0d on felix/mac-render-tests
into 230104f on master.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses one of the biggest inefficiences working with deck.gl, being that I have to rely on deck's CI during integration.

(Another issue is that deck's CI is quite slow relative to e.g. luma.gl etc and could stand to be optimized, but the urgency of that is significantly reduced by this change).

As minor nits:

  • I would avoid capital case in file names. Either call toLowerCase on the OS constant, or update the constants to be lower case.
  • I would add also string literal types to the OS constant.
let OS: 'mac' | 'windows' | 'unknown';

Additionally noting that it might be desirable to consolidate platform detection.

  • We have platform detection in luma.gl's device.info that I have been using to disable some local tests when running under mac OS.
  • We have similar platform detection in probe.gl

@Pessimistress
Copy link
Collaborator

Pessimistress commented Sep 25, 2024

Opportunity to enable TextLayer tests on CI?

export default OS === 'Mac'
? [
{

@felixpalmer
Copy link
Collaborator Author

Opportunity to enable TextLayer tests on CI?

export default OS === 'Mac'
? [
{

Good idea, but they need to be generated on Linux. Would you mind @Pessimistress ?

@felixpalmer
Copy link
Collaborator Author

Additionally noting that it might be desirable to consolidate platform detection.

Yes, it could be nice to move the override functionality into probe.gl as there we could check if the file existed prior to running the check

@felixpalmer felixpalmer merged commit 728d9a6 into master Sep 26, 2024
4 checks passed
@felixpalmer felixpalmer deleted the felix/mac-render-tests branch September 26, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants