Remove updateModuleSettings from codebase #9160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 18, 2024
felixpalmer
changed the title
ibgreen
approved these changes
Sep 20, 2024
| @@ -1107,6 +1109,12 @@ export default abstract class Layer<PropsT extends {} = {}> extends Component< | |||
| lightSources | |||
| } = moduleParameters; | |||
|
|
|||
| const maskProps = { | |||
There was a problem hiding this comment.
The type is in deck.gl/extensions and it is an open question whether this is the correct place to update the ShaderInputs as in many cases the referenced ShaderModules will not be present. Agree that we should type, will revisit when cleaning up, e.g. moving the shaderInputs.setProps into the extensions
Pessimistress
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8997
To merge
fp64module in luma needs to be ported to UBO, for now a manual hack is included hereChange List
updateModuleSettingsfromHeatmapLayerupdateModuleSettingsfromLayermaskPropsviaShaderInputs