Fix countItems in DataFilterExtension #9158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
commented
Sep 17, 2024
| @@ -19,7 +18,8 @@ const float component = 1.0 / 255.0; | |||
|
|
|||
| void main() { | |||
| #ifdef FLOAT_TARGET | |||
| dataFilter_value *= float(filterIndices != filterPrevIndices); | |||
| // BUG: always 0 for some reason | |||
| // dataFilter_value *= float(filterIndices != filterPrevIndices); | |||
There was a problem hiding this comment.
@Pessimistress any idea why this is broken? I've tried different variants of the check and it always evaluates to 0. Perhaps there is something wrong with using vertexOffset?
There was a problem hiding this comment.
Subtle catch of v9 - when an attribute's descriptor contains shaderAttributes, the sub-attributes cannot use the same name.
There was a problem hiding this comment.
That is subtle indeed :) would be nice if the types could catch this
20 tasks
Pessimistress
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
countItemshas not been working since the upgrade to v9Change List
filterModelcreation