Skip to content

Commit

Permalink
fix(pydeck-carto): Fix missing global for pydeck-carto in 8.9 release…
Browse files Browse the repository at this point in the history
…, bump semver range to 8.9 (#8786)
  • Loading branch information
donmccurdy authored Apr 16, 2024
1 parent d7b2e11 commit 727c99a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion bindings/pydeck-carto/pydeck_carto/layer.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pydeck as pdk

H3_VERSION = "~3.7.*"
DECKGL_VERSION = "~8.8.*"
DECKGL_VERSION = "~8.9.*"

LIBRARIES_TO_INCLUDE = [
f"npm/h3-js@{H3_VERSION}/dist/h3-js.umd.js",
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/pydeck/frontend_semver.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
DECKGL_SEMVER = "~8.8.*"
DECKGL_SEMVER = "~8.9.*"
3 changes: 2 additions & 1 deletion bindings/pydeck/pydeck/io/html.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ def in_jupyter():


def convert_js_bool(py_bool):
if type(py_bool) is bool:
"""Serializes Python booleans to JavaScript. Returns non-boolean values unchanged."""
if type(py_bool) is not bool:
return py_bool
return "true" if py_bool else "false"

Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/requirements/requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ flake8
requests
sphinx
recommonmark
jupyterlab
jupyterlab<4.0.0
ipython>=5.8.0;python_version<"3.4"
semver # necessary for PEP440-compliant semantic versions
sphinx-markdown-builder
Expand Down
4 changes: 4 additions & 0 deletions modules/carto/bundle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@ import * as CartoUtils from './src';
export * from '../layers/bundle/peer-dependency';

export const carto = CartoUtils;

// Export carto layer library for pydeck integration
// More info: https://github.com/ajduberstein/pydeck_custom_layer
globalThis.CartoLayerLibrary = CartoUtils;

0 comments on commit 727c99a

Please sign in to comment.