Implement TDVF and INIT_VCPU #7
Conversation
jakecorrenti
force-pushed
the
tdvf-and-init-vcpu
branch
2 times, most recently
from
fe25d9d
to
9e1a7a1
Compare
There was a problem hiding this comment.
Nice work, I've suggested a few changes.
Side note: There are a lot of functional changes here for this to be only one commit (IMO it can be easily broken into 4+ commits). While its fine for now and you don't need to change, it is good practice to create commits with small modular changes that either introduce new functionality or fix something. This can ease the burden on a reviewer when trying to review code submitted.
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
jakecorrenti
force-pushed
the
tdvf-and-init-vcpu
branch
from
9e1a7a1
to
40e06b8
Compare
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
jakecorrenti
force-pushed
the
tdvf-and-init-vcpu
branch
from
40e06b8
to
70dd780
Compare
src/launch/mod.rs
Outdated
| fn try_from(fd: &'a mut kvm_ioctls::VcpuFd) -> Result<Self, Self::Error> { | ||
| // need to enable the X2APIC bit for CPUID[0x1] so that the kernel can call | ||
| // KVM_SET_MSRS(MSR_IA32_APIC_BASE) without failing | ||
| let kvm = Kvm::new()?; |
There was a problem hiding this comment.
I think we should be re-using the Kvm that we initialized the vCPU with. We should include that in this.
impl<'a> TryFrom<(&'a mut kvm_ioctls::VcpuFd, &'a mut kvm_ioctls::Kvm)> for TdxVcpu<'a>
There was a problem hiding this comment.
the TryFrom trait only allows one argument from what I can see
There was a problem hiding this comment.
the
TryFromtrait only allows one argument from what I can see
I misread your code snippet, please disregard
Signed-off-by: Jake Correnti <[email protected]>
jakecorrenti
force-pushed
the
tdvf-and-init-vcpu
branch
from
70dd780
to
642c1d6
Compare
Adds a module that will provide an API for TDVF (TDX Virtual Firmware).
Adds the API to initialize a VCPU for TDX.