Use Qt 5.12.3 to work around macOS issues. #1558
Conversation
This is a proprietary codec and it's uncertain who can use it, and under what conditions. At this point, Opus is stable and a suitable replacement.
JulianGro
added
needs testing (QA)
|
Oh wow! I am absolutely loving PR 1558 !!! This is the best macOS interface yet! It is stable and movement smooth (not as much lag during loading). This should go into production. |
digisomni
added
QA Approved
|
Maybe before each if statement we should have a "TODO" noting that it's a hack and may not really last long term as we have to move up in Qt versions over time which includes reworking more code. |
|
That would make the code even messier than it already is, and all occurrences can be found by the same if statement. |
|
We actually also have if statements like this in the code already. |
digisomni
changed the title
|
Sorry for the late comment on this, but is the goal to downgrade all macOS builds or split out "Big Sur" from the mac builds to resolve Steve's issue? If this PR is doing the former, then it will break web entity support for zoom/google docs/ etc, |
|
I don't see how downgrading all builds would not break web entity support while a secondary build works. Whatever the case, this works around all the OpenGL issues. If the current client works on your mac that is fine but that is an exception. Without this PR there is crashes on startup, crashes on resizing window, and freezes on startup on most Apple machines running macOS Big Sur or newer. |
|
So turns out I was running the release candidate for Selene on my MacBook, thus crossed out last part above. Testing with the full 2022.1.0 release it is also failing to launch for me. In fact, 2021.1.3 and 2021.1.2 also fail to launch, but 2021.1.1 works (and use the "interface" client before it was renamed to Vircadia). The concern with downgrading QT, is it will break web entity support for certain applications like Zoom and Google Docs, so would be a step backward, but I can understand not a lot of mac users probably need this support right now. I would think we should be investigating why the Selene RC build and 2021.1.1 (and prior) worked fine with QT 5.15.2 on mac. So I hope this PR fix to rollback QT is only temporary. |
Will it break support or have you actually tested the PR?
I know why some builds worked and some didn't. Try fullscreen mode on that RC build you have been using. This PR is to gain some time. If we don't get Metal support somehow, we will eventually not be able to run on macOS anymore. |
Tell accountmanager url changed
set the new MS url for Overte: https://overte.org/mvs
update federation.json with the new MS url for Overte.
Ressources rebranding for Overte (mostly images, icon, model updated with Overte brand) some file has been edited to replace some files (they had vircadia in the name) Most of this has not been tested. (cause I don't build)
Replaced by brand-logo.svg
Replaced by: logo_overte.fbx logo_overte_white-color-emissive.fst
Replaced by brand.png
Replaced by : brand-logo-512.png
…rse server address
This rebrands the resource used for the installer. Note 1: I have not upgrade the file under "launchers" directory, these are visibly not used (still High Fidelity brand) Note 2: There is one file I can't modify: "install-folder.rsrc". There is nothing to edit that on the web... this would need a mac. Note 3: there was a slogan on 2 pictures under the logo: "virtual realities for one, for all". I left this blank for now... We would need a slogan to replace tit.
New Overte logo in a better size and spacing
Adjustment for Logo ratio
This reverts commit 2400bc9.
Logo ratio adjustment
Resources Rebranding for Overte
|
This PR needs to be updated from Vircadia master. |
digisomni
added
do not merge
|
Hello! Is this still an issue? |
This PR works around the issues we are experiencing when mixing macOSXSDK10.12 with Qt 5.15.2.
Fixes #1516
Depends on PR #1556
Tested on macOS Big Sur