Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for tulu.la event aggregator #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

m0sth8
Copy link

@m0sth8 m0sth8 commented Nov 1, 2019

I added --source argument to refresh command that allows user to choose between different sources.

conrad refresh --source=tulula imports 770 new events from tulu.la.

fix #28

@vinayak-mehta
Copy link
Owner

@m0sth8 Thanks for the PR!

The updation and consumption of data/events.json are decoupled by design. The plan is to run every scraper in the scrapers folder daily, remove duplicates, update the data/events.json and raise a bot pull request. This will also help ensure that all these changes are version controlled. I'll work on this flow this weekend.

conrad refresh should give the user all events in data/events.json, which they can then filter by tag, name, source etc.

At the same time, I think we should add a list of all sources at the top of the README for attribution.

Can you give me push access to this branch on your fork? I will make the required changes after setting up that flow, update this PR and merge it.

Thanks for building http://tulu.la!

@m0sth8
Copy link
Author

m0sth8 commented Nov 1, 2019

Oh, I see!

Unfortunately, we don't want data from Tulu.la to be decoupled from the service itself and stored outside because of many reasons, including rights on content, that we can't guarantee to allow permission for third party (Tulu.la is partly user generated content and partly curated content)

What we can do is to make and support a fork for those who wants to sync with both conrad/events.json and tulu.la.

Thank you for your project.

@vinayak-mehta
Copy link
Owner

vinayak-mehta commented Nov 3, 2019

Unfortunately, we don't want data from Tulu.la to be decoupled from the service itself and stored outside because of many reasons

@m0sth8 I see, but with the current crawler implementation, the data will be stored outside of tulu.la in a user's system.

I also went through the tulu.la terms of service which states that "You may crawl the forum and site to index it for a publicly available search engine, if you run one." - https://tulu.la/policy/terms/

If possible, would love to add a tulu.la crawler to conrad. It'll run once/twice a week. More details here: https://conference-radar.readthedocs.io/en/latest/dev/adding-crawlers.html

And if not, I could prioritize #3, which would be kinda like a git remote add letting the user configure a new source, so that they can consume events from it.

Would love to know your thoughts on this. :)

@m0sth8
Copy link
Author

m0sth8 commented Nov 4, 2019

Hi @vinayak-mehta,

It's fine to store data in user's system like a cache in browser. We don't want to store data in third party systems, e.g events.json on github.

I'm not sure that I understand #3 . How is it going to work?

@vinayak-mehta
Copy link
Owner

Similar to this, but a different interface than conrad refresh. The data will not be stored on GitHub and directly go to the user's computer. Can you give me push access to this branch on your fork? I'll make updates to this PR sometime this/next week.

@vinayak-mehta vinayak-mehta changed the title Add support for tulu.la event aggregator [WIP] Add support for tulu.la event aggregator Nov 5, 2019
@m0sth8
Copy link
Author

m0sth8 commented Nov 6, 2019

@vinayak-mehta sounds good!
I think you should have access to the pr as a maintainer of conrad.

At least github says:
If checked, users with write access to vinayak-mehta/conrad can add new commits to your 28 branch. You can always change this setting later.

@vinayak-mehta
Copy link
Owner

Oh, I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with tulu.la
2 participants