vimc-4530: Add monitoring of buildkite agents #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richfitz
requested changes
Feb 28, 2022
config/prometheus/alert-rules.yml
Outdated
| annotations: | ||
| error: "buildkite-agent-metrics is down" | ||
| - alert: AgentsDown | ||
| expr: buildkite_total_total_agent_count{job="buildkite-metrics"} < 10 |
There was a problem hiding this comment.
please make this queue specific
richfitz
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses https://github.com/buildkite/buildkite-agent-metrics
This just checks that there are more than 10 running, but gives us the ability to check some more detailed metrics see https://github.com/buildkite/buildkite-agent-metrics#metrics
As part of this I have added docker build from buildkite-agent-metrics Dockerfile which is here https://github.com/reside-ic/buildkite-agent-metrics it looks like they don't build an official one buildkite/buildkite-agent-metrics#51 and other ones are out of date. I think I should probably set this to run on a schedule to keep it up to date, every month? I feel like this is a bit fragile to the structure of that repo changing so would be keen to hear alternatives
I've deployed this branch and seen it working, you can see an alert here https://teams.microsoft.com/l/message/19:[email protected]/1645118508085?tenantId=2b897507-ee8c-4575-830b-4f8267c3d307&groupId=ba231111-1572-42ae-981e-c8bc7aa681ef&parentMessageId=1645118508085&teamName=DIDE%20-%20WP&channelName=reside-monitor&createdTime=1645118508085