Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to svelte5 #324

Merged
merged 3 commits into from
Oct 19, 2024
Merged

update to svelte5 #324

merged 3 commits into from
Oct 19, 2024

Conversation

ryoppippi
Copy link
Member

svelte5.0.0 正式版にアプデ!

Copy link

cloudflare-workers-and-pages bot commented Oct 19, 2024

Deploying vim-jp-radio-lp with  Cloudflare Pages  Cloudflare Pages

Latest commit: bdd0cc0
Status: ✅  Deploy successful!
Preview URL: https://236da58d.lp-d1f.pages.dev
Branch Preview URL: https://svelte5.lp-d1f.pages.dev

View logs

@ryoppippi
Copy link
Member Author

tweet取得でミスってるので https://github.com/vim-jp-radio/LP/pull/325 の後にmerge

@ryoppippi ryoppippi marked this pull request as draft October 19, 2024 17:50
auto-merge was automatically disabled October 19, 2024 17:50

Pull request was converted to draft

@ryoppippi
Copy link
Member Author

rebaseしました

@ryoppippi
Copy link
Member Author

ビルドが通ることを確認

@ryoppippi ryoppippi marked this pull request as ready for review October 19, 2024 17:58
@ryoppippi
Copy link
Member Author

レビューお願いします!

Copy link
Contributor

@tomoya tomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryoppippi ryoppippi merged commit c531191 into main Oct 19, 2024
3 checks passed
@ryoppippi ryoppippi deleted the svelte5 branch October 19, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants