Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove html-minifier #321

Merged
merged 1 commit into from
Oct 7, 2024
Merged

chore: remove html-minifier #321

merged 1 commit into from
Oct 7, 2024

Conversation

ryoppippi
Copy link
Member

@ryoppippi ryoppippi commented Oct 5, 2024

最新のsvelteと相性が良くないらしく、一旦 sveltekit-html-minifierを外します
実際、svelteの最新版でエラーが発生しているので、一旦のぞきます

sveltejs/svelte#13510

Copy link

cloudflare-workers-and-pages bot commented Oct 5, 2024

Deploying vim-jp-radio-lp with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4812524
Status: ✅  Deploy successful!
Preview URL: https://16ba8dcf.lp-d1f.pages.dev
Branch Preview URL: https://feature-remove-minifier.lp-d1f.pages.dev

View logs

@ryoppippi
Copy link
Member Author

マージしちゃっても良いですか?

@ryoppippi
Copy link
Member Author

@tomoya ping
表示は問題なさそうです!

Copy link
Contributor

@tomoya tomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryoppippi ryoppippi merged commit 429f1a1 into main Oct 7, 2024
2 checks passed
@ryoppippi ryoppippi deleted the feature/remove-minifier branch October 7, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants