Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 update dependencies #294

Closed
wants to merge 3 commits into from

Conversation

vim-denops-machine-user
Copy link

@vim-denops-machine-user vim-denops-machine-user commented Nov 27, 2023

  • 📦 bump deno.land/std from 0.204.0 to 0.210.0
  • 📦 bump deno.land/x/denops_test from v1.4.0 to v1.5.1
  • 📦 bump deno.land/x/vim_channel_command from v2.0.0 to v3.0.0

Summary by CodeRabbit

  • Refactor
    • Updated various dependencies to enhance performance and compatibility.

Copy link

coderabbitai bot commented Nov 27, 2023

Walkthrough

The updates reflect a version bump for various Deno standard library imports across multiple files. The parse function from the flags module, as well as the vim_channel_command module, and the path, assert, and semver modules, have all been upgraded to newer versions, indicating maintenance for compatibility with updated library versions and potential enhancements to functionality or APIs.

Changes

File Path Change Summary
.../@denops-private/cli.ts,
.../@denops-private/service.ts,
.../@denops-private/version.ts
Updated flags, toFileUrl, path, and semver module versions from 0.204.0 to 0.210.0
.../@denops-private/host/vim.ts Updated vim_channel_command module version from 2.0.0 to 3.0.0
.../@denops-private/impl_test.ts Updated path and assert module versions from 0.204.0 to 0.210.0

🐇✨
Code hops along, versions leap high,
From 0.204.0 to 0.210.0 we fly.
Through fields of code, our updates roam,
In Deno's warren, we've found our home. 🌾🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b39cf7) 96.47% compared to head (04b92bf) 96.47%.

❗ Current head 04b92bf differs from pull request most recent head b3fbf30. Consider uploading reports for the commit b3fbf30 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files           3        3           
  Lines          85       85           
  Branches        6        6           
=======================================
  Hits           82       82           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vim-denops-machine-user vim-denops-machine-user force-pushed the automation/update-dependencies branch from cd7985f to a669494 Compare December 7, 2023 00:29
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c50865d and a669494.
Files selected for processing (8)
  • denops/@denops-private/cli.ts (1 hunks)
  • denops/@denops-private/error.ts (1 hunks)
  • denops/@denops-private/host/invoker.ts (1 hunks)
  • denops/@denops-private/host/nvim.ts (1 hunks)
  • denops/@denops-private/impl_test.ts (1 hunks)
  • denops/@denops-private/service.ts (1 hunks)
  • denops/@denops-private/version.ts (1 hunks)
  • denops/@denops-private/worker/script.ts (1 hunks)
Files skipped from review due to trivial changes (5)
  • denops/@denops-private/error.ts
  • denops/@denops-private/host/invoker.ts
  • denops/@denops-private/host/nvim.ts
  • denops/@denops-private/impl_test.ts
  • denops/@denops-private/version.ts
Additional comments: 5
denops/@denops-private/cli.ts (1)
  • 2-3: The import statements for streamtools and disposable modules are not mentioned in the PR objective or the summaries. Please verify if these changes are intended and if they align with the project's dependency update policy.

Verification result:

The import statements for streamtools and disposable modules have been found in multiple files within the codebase, indicating that the changes are consistent and likely intentional. However, these updates were not mentioned in the PR objectives or the AI-generated summaries. It is recommended to confirm that these changes align with the project's dependency update policy.

  • denops/@denops-private/trace_stream.ts: streamtools module is imported.
  • denops/@denops-private/cli.ts: Both streamtools and disposable modules are imported.
  • denops/@denops-private/service.ts: disposable module is imported.
  • denops/@denops-private/host/base.ts: disposable module is imported.
denops/@denops-private/service.ts (2)
  • 1-2: The updates to the import statements for deno.land/std and deno.land/x/unknownutil are correct and align with the PR objectives.

  • 3-3: No further changes are detected in the file outside of the updated import statements, which is consistent with the PR objectives and summaries.

denops/@denops-private/worker/script.ts (2)
  • 2-5: The update to the unknownutil module version from v3.10.0 to v3.11.0 is consistent with the PR objectives and the AI-generated summaries.

  • 6-8: The caret (^) symbol in the import statement for messagepack_rpc indicates that compatible versions are allowed. This is not mentioned in the PR objectives or summaries, suggesting it is intentional and not part of the updates.

@lambdalisue lambdalisue force-pushed the automation/update-dependencies branch from a669494 to b900e48 Compare December 11, 2023 05:43
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 886bfa0 and b900e48.
Files selected for processing (8)
  • denops/@denops-private/cli.ts (1 hunks)
  • denops/@denops-private/error.ts (1 hunks)
  • denops/@denops-private/host/invoker.ts (1 hunks)
  • denops/@denops-private/host/nvim.ts (1 hunks)
  • denops/@denops-private/impl_test.ts (1 hunks)
  • denops/@denops-private/service.ts (1 hunks)
  • denops/@denops-private/version.ts (1 hunks)
  • denops/@denops-private/worker/script.ts (1 hunks)
Files skipped from review due to trivial changes (3)
  • denops/@denops-private/cli.ts
  • denops/@denops-private/impl_test.ts
  • denops/@denops-private/worker/script.ts
Additional comments: 9
denops/@denops-private/error.ts (2)
  • 1-1: The import statement has been correctly updated to the new version of unknownutil.

  • 1-1: Verify that the updated version of unknownutil does not introduce breaking changes that affect the usage of is.String and is.Record in this file.


#!/bin/bash
# Fetch the mod.ts file from the unknownutil repository at the specified version
curl -s https://deno.land/x/[email protected]/mod.ts -o unknownutil_mod.ts

# Use ast-grep to search for the is.String and is.Record functions in the fetched file
ast-grep --lang typescript --pattern $'export function is($_) {
  $$$
  String($_) {
    $$$
  }
  $$$
  Record($_) {
    $$$
  }
  $$$
}' unknownutil_mod.ts
denops/@denops-private/host/invoker.ts (2)
  • 1-1: The import statement for unknownutil has been updated to version v3.11.0. Verify that the updated version does not introduce breaking changes or new features that might affect the usage of the is function.

The import statement for unknownutil has been updated to version v3.11.0. The verification script did not yield results, so further checks are needed to ensure the updated version does not introduce breaking changes affecting the is function.


The import statement for unknownutil has been updated to version v3.11.0. Attempts to verify the absence of breaking changes through changelog or release notes within the codebase were unsuccessful. Further verification from external sources or manual review of the updated module's documentation is recommended.

  • 1-4: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [2-50]

No further action required. The rest of the file remains unchanged, which is consistent with the PR's objective of updating dependencies without altering functionality.

denops/@denops-private/host/nvim.ts (1)
  • 1-1: The import statement for unknownutil has been updated to version v3.11.0. Verify that the updated version does not introduce breaking changes or new features that might affect the usage of assert and is functions.

The update to unknownutil version v3.11.0 in nvim.ts is consistent with the PR's objective to update dependencies. The shell script intended to check for breaking changes in the unknownutil changelog did not yield any results, which could mean the changelog is not present or the search term was not found. Without further information, we cannot confirm the absence of breaking changes. However, the PR's scope suggests that the update is expected to be non-breaking.

Final review comment:

The import statement for unknownutil has been updated as intended. Since the changelog check did not yield results, ensure to manually verify that v3.11.0 does not introduce breaking changes affecting the assert and is functions.

denops/@denops-private/service.ts (2)
  • 1-2: The updated import statements for path/mod.ts and unknownutil reflect the new versions correctly.

  • 1-2: Please ensure that the updated dependencies do not introduce breaking changes by running the project's test suite and checking the release notes of the updated dependencies.

denops/@denops-private/version.ts (2)
  • 1-5: The import paths for path/mod.ts and semver/mod.ts have been updated to version 0.208.0. Verify that the updated versions of these modules are compatible with the current codebase and do not introduce breaking changes.

#!/bin/bash
# Find CHANGELOG.md files for the `path` and `semver` modules and check for version `0.208.0`.
fd 'CHANGELOG.md' | grep 'path/mod.ts' | xargs rg '0\.208\.0'
fd 'CHANGELOG.md' | grep 'semver/mod.ts' | xargs rg '0\.208\.0'
  • 6-8: The rest of the file remains unchanged, and the updated import statements are correctly formatted.

@vim-denops-machine-user vim-denops-machine-user force-pushed the automation/update-dependencies branch from b900e48 to b9d87c9 Compare December 14, 2023 00:28
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 886bfa0 and b9d87c9.
Files selected for processing (8)
  • denops/@denops-private/cli.ts (1 hunks)
  • denops/@denops-private/error.ts (1 hunks)
  • denops/@denops-private/host/invoker.ts (1 hunks)
  • denops/@denops-private/host/nvim.ts (1 hunks)
  • denops/@denops-private/impl_test.ts (1 hunks)
  • denops/@denops-private/service.ts (1 hunks)
  • denops/@denops-private/version.ts (1 hunks)
  • denops/@denops-private/worker/script.ts (1 hunks)
Files skipped from review due to trivial changes (3)
  • denops/@denops-private/host/nvim.ts
  • denops/@denops-private/impl_test.ts
  • denops/@denops-private/version.ts
Additional comments: 7
denops/@denops-private/cli.ts (2)
  • 1-1: The version update for the parse function from [email protected] to [email protected] should be checked for any breaking changes or deprecations that could affect its usage in this file.

  • 2-4: Confirm that the versions for streamtools, disposable, service.ts, vim.ts, and nvim.ts are up to date and do not require similar version bumps.

denops/@denops-private/error.ts (1)
  • 1-1: The import statement has been updated to the new version v3.11.0 of unknownutil. Ensure that the updated version of unknownutil does not introduce breaking changes or require changes to the usage of the is function within this file.
denops/@denops-private/host/invoker.ts (1)
  • 1-1: The import statement for unknownutil has been updated to version v3.11.0. Verify that the new version of unknownutil is backward compatible and that the is function continues to work as expected.
denops/@denops-private/service.ts (2)
  • 1-2: The updates to the import statements for path/mod.ts and unknownutil/mod.ts are correct and align with the PR objectives to update dependency versions.

  • 1-2: Please ensure that the project's test suite is run to verify that the updated dependencies do not introduce any breaking changes or regressions.

denops/@denops-private/worker/script.ts (1)
  • 2-5: The update of the unknownutil module from v3.10.0 to v3.11.0 is consistent with the PR's objective to keep dependencies up to date.

@vim-denops-machine-user vim-denops-machine-user force-pushed the automation/update-dependencies branch from b9d87c9 to 3f90464 Compare December 22, 2023 00:28
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 886bfa0 and 3f90464.
Files selected for processing (8)
  • denops/@denops-private/cli.ts (1 hunks)
  • denops/@denops-private/error.ts (1 hunks)
  • denops/@denops-private/host/invoker.ts (1 hunks)
  • denops/@denops-private/host/nvim.ts (1 hunks)
  • denops/@denops-private/impl_test.ts (1 hunks)
  • denops/@denops-private/service.ts (1 hunks)
  • denops/@denops-private/version.ts (1 hunks)
  • denops/@denops-private/worker/script.ts (1 hunks)
Files skipped from review due to trivial changes (6)
  • denops/@denops-private/cli.ts
  • denops/@denops-private/error.ts
  • denops/@denops-private/host/invoker.ts
  • denops/@denops-private/host/nvim.ts
  • denops/@denops-private/impl_test.ts
  • denops/@denops-private/version.ts
Additional comments: 2
denops/@denops-private/worker/script.ts (1)
  • 5-5: The import statement for unknownutil has been correctly updated to the new version v3.11.0. Ensure that the updated module is compatible with the current codebase and that all tests pass.
denops/@denops-private/service.ts (1)
  • 1-2: The import statements for std and unknownutil have been correctly updated to the new versions 0.210.0 and v3.11.0, respectively. Ensure that the updated modules are compatible with the current codebase and that all tests pass.

@vim-denops-machine-user vim-denops-machine-user changed the title 📦 update dependencies 📦 bump deno.land/std from 0.204.0 to 0.210.0 Dec 31, 2023
@vim-denops-machine-user vim-denops-machine-user force-pushed the automation/update-dependencies branch from 3f90464 to bd08bcb Compare December 31, 2023 00:31
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 405e919 and bd08bcb.
Files selected for processing (4)
  • denops/@denops-private/cli.ts (1 hunks)
  • denops/@denops-private/impl_test.ts (1 hunks)
  • denops/@denops-private/service.ts (1 hunks)
  • denops/@denops-private/version.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • denops/@denops-private/service.ts
Additional comments: 3
denops/@denops-private/version.ts (1)
  • 4-5: Please verify that the updated versions of path and semver modules do not introduce breaking changes that could affect the existing functionality.
denops/@denops-private/cli.ts (1)
  • 1-1: Please verify that the updated version of the flags module does not introduce breaking changes that could affect the existing functionality.
denops/@denops-private/impl_test.ts (1)
  • 1-5: Please verify that the updated versions of path and assert modules do not introduce breaking changes that could affect the existing test functionality.

@vim-denops-machine-user vim-denops-machine-user changed the title 📦 bump deno.land/std from 0.204.0 to 0.210.0 📦 update dependencies Jan 1, 2024
@vim-denops-machine-user vim-denops-machine-user force-pushed the automation/update-dependencies branch from bd08bcb to 04b92bf Compare January 1, 2024 00:32
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b0812d3 and 04b92bf.
Files selected for processing (5)
  • denops/@denops-private/cli.ts (1 hunks)
  • denops/@denops-private/host/vim.ts (1 hunks)
  • denops/@denops-private/impl_test.ts (1 hunks)
  • denops/@denops-private/service.ts (1 hunks)
  • denops/@denops-private/version.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • denops/@denops-private/host/vim.ts
Files skipped from review as they are similar to previous changes (4)
  • denops/@denops-private/cli.ts
  • denops/@denops-private/impl_test.ts
  • denops/@denops-private/service.ts
  • denops/@denops-private/version.ts

@vim-denops-machine-user vim-denops-machine-user force-pushed the automation/update-dependencies branch from 04b92bf to b3fbf30 Compare January 3, 2024 00:28
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8b39cf7 and b3fbf30.
Files selected for processing (5)
  • denops/@denops-private/cli.ts (1 hunks)
  • denops/@denops-private/host/vim.ts (1 hunks)
  • denops/@denops-private/impl_test.ts (1 hunks)
  • denops/@denops-private/service.ts (1 hunks)
  • denops/@denops-private/version.ts (1 hunks)
Files skipped from review as they are similar to previous changes (5)
  • denops/@denops-private/cli.ts
  • denops/@denops-private/host/vim.ts
  • denops/@denops-private/impl_test.ts
  • denops/@denops-private/service.ts
  • denops/@denops-private/version.ts

@lambdalisue
Copy link
Member

Closed due to #302

@lambdalisue lambdalisue closed this Feb 3, 2024
@lambdalisue lambdalisue deleted the automation/update-dependencies branch February 3, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants