Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the clear expired locks commands be compatible with Django >= 1.10 #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexagrf
Copy link

@alexagrf alexagrf commented Sep 9, 2016

NoArgsCommand got removed. Django also doesn't use optparse any more.

Patch is a bit ugly, but it has the benefits of being feature-checking instead of version checking

@Duologic
Copy link
Contributor

Hi @alexagrf

We are trying to get some order in the repository and merged the branch we were using in production into master. Would you mind rebasing your pull request on the current master?

I can then poke some people to review and test.

@alexagrf
Copy link
Author

I don't think this patch is needed any more, since you removed that function and moved it to a celery task.
Would it be possible to make celery an optional dependency instead? In that case, this patch could stay for non-celery users like me.

@Duologic
Copy link
Contributor

We could move locking.tasks.clean_expired_locks() to locking.utils and call locking.utils.clean_expired_locks() from both the locking.tasks and the management command. This would make celery and optional requirement to run the clean task.

@Duologic
Copy link
Contributor

FYI, we are also working on Python 2/3 compatibility and supporting multiple Django versions on this branch: #35 This will probably go live pretty soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants