-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling app window feature added #49
Conversation
The code seems to be fine but there are some formatting inconsistencies like redundant blank lines after if statement and more. Clear those issues and I will merge this PR. I am marking some of the inconsistencies in |
src/Assistant.py
Outdated
import Support | ||
from VoiceInterface import VoiceInterface | ||
|
||
LISTENING_ERROR = "Say that again please..." | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two line gap is enough...no need for having three blank lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept only two blank lines.
src/Assistant.py
Outdated
@@ -40,15 +43,17 @@ def listen_for_query(self) -> str: | |||
|
|||
|
|||
def execute_query(self, query: str) -> None: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the lines
src/Assistant.py
Outdated
if scroll_thread is not None: | ||
Support.stop_scrolling() | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary gap between two elif
blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the blank lines. I also went the through the Support.py
file then identified and removed some redundant/blank lines too.
give @RahatAhmed171 100 points |
Ping me once on discord if points are not reflected on slop leaderboard |
Issue Referenced
<issue #7 >
Describe the Changes
Using Desktop Assistant, now a user can scroll any app window in three ways through the voice commands below:
Change 1: <src/Assistant.py>
To detect the scrolling commands and handling the condition when the query is
None
Change 2: <src/Support.py>
lmplementing the code to scroll
Change 3: <src/VoiceInterface.py>
Correcting a typo in the code
Type of Change
Additional Setup Requirements
To run the added feature you need to install:
pip install pyautogui
and
pip install Pillow
Neccessary Conditions