Allow top level generator types for actions #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhunzaker
force-pushed
the
react-router-revise
branch
from
d7c73b6 to
6e24813
Compare
nhunzaker
force-pushed
the
action-generator-revise
branch
from
00bf4e8 to
c4239e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 25 25
Lines 858 861 +3
=====================================
+ Hits 858 861 +3
Continue to review full report at Codecov.
|
nhunzaker
force-pushed
the
action-generator-revise
branch
2 times, most recently
from
ee9e9db to
94c7e17
Compare
nhunzaker
force-pushed
the
react-router-revise
branch
from
6e24813 to
76a5899
Compare
nhunzaker
force-pushed
the
action-generator-revise
branch
2 times, most recently
from
bb3e4c4 to
eb4a27e
Compare
This commit adds a short-hand for generator actions. For example:
```javascript
let count = n => n
function * range (repo, start, end) {
while (start <= end)
yield repo.push(count, start++)
}
}
repo.push(range, 1, 10) // 1,2,3,4,5,6,7,8,9,10
```
nhunzaker
force-pushed
the
action-generator-revise
branch
from
eb4a27e to
50ce69e
Compare
|
I'm going to leave this alone for the time being. I want to get some planning in place first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a short-hand for generator actions. For example:
Related to #346