Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RSDK-8293] Pass in Connection to Answerer in WebRTC Server #4762

Merged
merged 5 commits into from
Feb 5, 2025
Merged

[RSDK-8293] Pass in Connection to Answerer in WebRTC Server #4762

merged 5 commits into from
Feb 5, 2025

Conversation

bashar-515
Copy link
Member

@bashar-515 bashar-515 commented Jan 30, 2025 •
edited
Loading

This PR includes our global connection to App as a WebRTC option for the external signaling answerer to use.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 30, 2025
@bashar-515 bashar-515 requested a review from cheukt January 31, 2025 19:24
@bashar-515 bashar-515 marked this pull request as ready for review January 31, 2025 19:24
@bashar-515
Copy link
Member Author

Tests will fail until we bump Goutils.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 31, 2025
@bashar-515 bashar-515 mentioned this pull request Jan 31, 2025
Closed
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Feb 4, 2025
@bashar-515 bashar-515 marked this pull request as draft February 5, 2025 16:04
@bashar-515 bashar-515 marked this pull request as ready for review February 5, 2025 16:04
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Feb 5, 2025
@bashar-515 bashar-515 marked this pull request as draft February 5, 2025 16:12
@viambot viambot removed the safe to test This pull request is marked safe to test from a trusted zone label Feb 5, 2025
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Feb 5, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Feb 5, 2025
@bashar-515 bashar-515 marked this pull request as ready for review February 5, 2025 16:37
@bashar-515 bashar-515 merged commit cfd9b85 into viamrobotics:main Feb 5, 2025
16 checks passed
@bashar-515 bashar-515 deleted the RSDK-8293 branch February 5, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheukt cheukt cheukt approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bashar-515 @cheukt @viambot