Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-9748 Wait for machine to be running in module interceptors test #4718

Merged
merged 1 commit into from
Jan 16, 2025
Merged

RSDK-9748 Wait for machine to be running in module interceptors test #4718

merged 1 commit into from
Jan 16, 2025

Conversation

benjirewis
Copy link
Member

No description provided.

@benjirewis benjirewis requested a review from dgottlieb January 15, 2025 21:33
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jan 15, 2025
@benjirewis
Copy link
Member Author

Reproed test failure on head of main by running with -race (I think race detection changed timing enough to allow the client code to try to access the generic helper client while the machine was still initializing.) Can't repro with change in this PR.

@benjirewis benjirewis merged commit 7ae017d into viamrobotics:main Jan 16, 2025
16 checks passed
@benjirewis benjirewis deleted the module-interceptors-test-fix branch January 16, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgottlieb dgottlieb dgottlieb approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjirewis @dgottlieb @viambot