Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3453: Explicitly state there's no model available to mirror the camera image #3918

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sguequierre
Copy link
Collaborator

We got this q a couple times and the ai bot suggested the transform camera with no specific model so I figured it might be best to explicitly state it

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 27, 2025
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit eede989
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/6797ecc2458f970008e49d8a
😎 Deploy Preview https://deploy-preview-3918--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 34 (🟢 up 7 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you adding this here for the chatbot to know or because you think this will be useful to general docs readers? If it's only for the chatbot to know, I think this is where we'd want to add a hidden page with some facts for the AI chatbot instead and put that there instead.

If you do want to keep it here and think it's the right place to generally inform people, then please be aware that you will need to check new camera models periodically to see if this statement is still true. Most often these sort of statements do not get maintained. So I would recommend not adding it.

@sguequierre sguequierre requested a review from npentrel January 27, 2025 18:43
Comment on lines +11 to +13
_build:
render: false
list: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do these do? Are they needed?

Copy link
Collaborator Author

@sguequierre sguequierre Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re. slack thread-- they make the link a 404. I thought it was needed so someone couldn't accidentally go to the page just in case

@sguequierre sguequierre requested a review from npentrel January 28, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants