Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3355: Update visualize.md for time series widget upgrades #3835

Merged
merged 3 commits into from
Jan 10, 2025
Merged

DOCS-3355: Update visualize.md for time series widget upgrades #3835

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e2fa78
Update visualize.md
sguequierre Jan 10, 2025
4ee3cf2
Apply suggestions from code review
sguequierre Jan 10, 2025
e2e5f8c
Apply suggestions from code review
sguequierre Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/data-ai/data/visualize.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Give it a name.
Click **Add widget** and select the appropriate widget for your machine.
Repeat as many times as necessary.

Click **Add widget** and add a **GPS** widget for a movement sensor and a **time series** or **stat** widget for a sensor.
Click **Add widget** and add a **GPS** widget for a movement sensor, a **stat** widget for a sensor, and a **time series** widget for any component that supports capturing numeric data.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be a GPS widget for a GPS? Not for any movement sensor? Or does a GPS widget support an accelerometer?

Suggested change
Click **Add widget** and add a **GPS** widget for a movement sensor, a **stat** widget for a sensor, and a **time series** widget for any component that supports capturing numeric data.
Click **Add widget** and add a **GPS** widget for a GPS, a **stat** widget for current readings from a sensor, or a **time series** widget to graph data for any component that supports capturing numeric data.

App says sensor could be stat or time series...could stat also be any component that supports capturing numeric data? If so that should be made clear

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checked with zach and this is gps, wheeled odometry, and also any custom modular implementation-- anything that reports GetPosition. Stat is still just sensor but that will change eventually.

sguequierre marked this conversation as resolved.
Show resolved Hide resolved

{{% /tablestep %}}
{{% tablestep %}}
Expand All @@ -67,7 +67,7 @@ Select **Monitor** in the top right corner to leave editing mode.
Click **Select machine** and select your configured machine.

Your dashboard now shows the configured widget for the data from your machine.
For example, a time series graph measuring noise over time:
For example, a time series graph measuring noise over time for a sensor component:

{{< imgproc src="/services/data/time-series.png" alt="Time series widget measuring noise over time." style="width:500px" resize="1200x" class="imgzoom fill" >}}

Expand Down
Loading