-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-3087: Add Python export tabular data to automation #3834
DOCS-3087: Add Python export tabular data to automation #3834
Conversation
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3834 |
@@ -0,0 +1 @@ | |||
Obtain unified tabular data and metadata from the specified data source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own understanding, does this need to be here because the automation wouldn't pull this description from the Python SDK and only looks to the proto which doesn't have this description? Wouldn't it be better to edit https://github.com/viamrobotics/api/blob/3f0b40a80d223721fce7e385afe026aeeb6bd4fc/proto/viam/app/data/v1/data.proto#L24 instead of creating an override?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wasn't working for me if I didn't create an override, it gave me an error and didn't pick up the description properly. @npentrel have you encountered this before? I don't understand the automation well enough currently to easily fix it but I could take a stab if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the automation requires it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and yes this is not ideal but not something that's easy to fix at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % override question
No description provided.