Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3087: Add Python export tabular data to automation #3834

Merged

Conversation

sguequierre
Copy link
Collaborator

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 10, 2025
@viambot
Copy link
Member

viambot commented Jan 10, 2025

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3834

@@ -0,0 +1 @@
Obtain unified tabular data and metadata from the specified data source.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own understanding, does this need to be here because the automation wouldn't pull this description from the Python SDK and only looks to the proto which doesn't have this description? Wouldn't it be better to edit https://github.com/viamrobotics/api/blob/3f0b40a80d223721fce7e385afe026aeeb6bd4fc/proto/viam/app/data/v1/data.proto#L24 instead of creating an override?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasn't working for me if I didn't create an override, it gave me an error and didn't pick up the description properly. @npentrel have you encountered this before? I don't understand the automation well enough currently to easily fix it but I could take a stab if necessary.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the automation requires it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and yes this is not ideal but not something that's easy to fix at the moment.

Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % override question

@sguequierre sguequierre changed the title Add Python export tabular data to automation DOCS-3087: Add Python export tabular data to automation Jan 10, 2025
@sguequierre sguequierre merged commit 7de5fb3 into viamrobotics:main Jan 10, 2025
8 of 9 checks passed
@sguequierre sguequierre deleted the DOCS-3087/export-tabular-data branch January 10, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants