Removed front-end of saved list feature #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupeDeDupe
commented
Apr 15, 2019
| @@ -91,7 +91,7 @@ describe("BenefitCard", () => { | |||
|
|
|||
| it("Clicking the See More button expands the BenefitExpansion component", () => { | |||
| mountedBenefitCard() | |||
| .find("HeaderButton") | |||
| .find("BenefitExpansion") | |||
There was a problem hiding this comment.
This seems to have never been fixed when the See More button was changed to a toggle. The "HeaderButton" should have been replaced with "BenefitExpansion." This whole time, the test was picking up the HeaderButton from the saved list button on the benefit card.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2084. I only commented out the saved list UI parts and made the favourites page inaccessible on the prod environment. I think it's relevant to keep the backend fragments of the saved list feature for now, as some of it will be reusable in the feature which is to replace it.
There will have to be a thorough cleaning to refine the code: #2086