Merge pull request #163 from tsegismont/issue/162

Different start method in Get Started guide and starter
vertx-web-site · Sep 14, 2024 · aac3014 · aac3014
2 parents 0416664 + a729217
commit aac3014
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/assets/get-started/starter-screenshot.png b/assets/get-started/starter-screenshot.png
diff --git a/pages/get-started.mdx b/pages/get-started.mdx
@@ -65,9 +65,18 @@ Change the code as follows:
 <CodeExample title="Java">
 
 ```java
+package com.example.starter;
+
+import io.vertx.core.AbstractVerticle;
+import io.vertx.core.MultiMap;
+import io.vertx.core.Promise;
+import io.vertx.core.json.JsonObject;
+import io.vertx.ext.web.Router;
+
 public class MainVerticle extends AbstractVerticle {
+
   @Override
-  public void start() throws Exception {
+  public void start(Promise<Void> startPromise) throws Exception {
     // Create a Router
     Router router = Router.router(vertx);
 
@@ -93,12 +102,16 @@ public class MainVerticle extends AbstractVerticle {
       .requestHandler(router)
       // Start listening
       .listen(8888)
-      // Print the port
-      .onSuccess(server ->
-        System.out.println(
-          "HTTP server started on port " + server.actualPort()
-        )
-      );
+      // Print the port on success
+      .onSuccess(server -> {
+        System.out.println("HTTP server started on port " + server.actualPort());
+        startPromise.complete();
+      })
+      // Print the problem on failure
+      .onFailure(throwable -> {
+        throwable.printStackTrace();
+        startPromise.fail(throwable);
+      });
   }
 }
 ```