Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Evaluation Metrics and HTML minifier #14

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Improve Evaluation Metrics and HTML minifier #14

merged 4 commits into from
Nov 14, 2024

Conversation

Neeraj319
Copy link
Member

@Neeraj319 Neeraj319 commented Nov 12, 2024

Pull Request Summary

This PR includes the following changes:

Changes in htmlMinifier.js

  • Added a custom attribute data-supported-primitives to the minified HTML.
    • This attribute helps the LLM (Language Model) identify if an element is clickable, hoverable, etc.
  • Added helper functions:
    • isClickable: Determines if an element is clickable.
    • isHoverable: Determines if an element is hoverable.
    • canInputText: Determines if an element can accept text input.

Updates in the eval/ folder

  • Updated evaluations for the following sites:
    • bigbasket
    • flipkart
    • makemytrip
  • Added an evaluation for 99bikes.com.
  • Removed evaluation for jackphelanchevy.info due to constant blocking issues.

Log Line Improvements

  • Improved log messages for better clarity.

@Neeraj319
Copy link
Member Author

#5 #6

Copy link
Collaborator

@CaffeineDuck CaffeineDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

meta/htmlMinifier.js Show resolved Hide resolved
meta/htmlMinifier.js Outdated Show resolved Hide resolved
@Neeraj319 Neeraj319 merged commit 3c5eaa7 into main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants