Always return a 415 if the content type is mismatching, also if its value is empty #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsegismont
approved these changes
Oct 17, 2024
|
@komape could you take care of backporting to |
|
@tsegismont Thanks for merging and the quick response!
How do I this? What exactly do you mean? |
|
I mean creating another PR for branch |
This was referenced Oct 18, 2024
|
@tsegismont Now I understand. Opened the PR #2659. |
code-brazier
pushed a commit
to code-brazier/vertx-web
that referenced
this pull request
Dec 23, 2024
…alue is empty (vert-x3#2657) * Always return a 415 if the content type is mismatching, also if its value isempty * Update RouterTest to expect 415 for missing content type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Solves the bug described in #2656. Instead of returning a 400 in case of a missing content type, it now returns a 415. For further details, see the issue.
It does not add the return of an
Acceptheader in case of a mismatched content type. But I would not see this as a bug but rather as an enhancement which needs its own issue.Currently waiting for an account with the Eclipse Foundation but they currently experience issues with user sign up. I will sign the ECA as soon as possible.
EDIT: Signed the ECA.