Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Meson to 1.5.0 #1424

Merged
merged 16 commits into from
Jul 18, 2024
Merged

Update Meson to 1.5.0 #1424

merged 16 commits into from
Jul 18, 2024

Conversation

ibc
Copy link
Member

@ibc ibc commented Jul 6, 2024

I've seen some -undefined not supported error when trying to build worker tests with Address Sanitizer in macOS (which is not supported anyway) and it went away after updating Meson.

I've seen some `-undefined` not supported when trying to build worker tests with Address Sanitizer in macOS (which is not supported anyway) and it went away updating Meson to 1.4.1, so why not?
@ibc ibc requested review from jmillan and nazar-pc July 6, 2024 12:43
@ibc
Copy link
Member Author

ibc commented Jul 6, 2024

Another relevant thing: I see this logs when building worker-test-asan-address:

meson.build:483: WARNING: Trying to use address sanitizer on Clang with b_lundef.
This will probably not work.
Try setting b_lundef to false instead.

I see this: mesonbuild/meson#764

If I don't specify -Db_lundef=false at the same time I specify -Db_sanitize=address I get linker errors when building shared objects.

I've added that argument c8e6af4 but CI also fails: https://github.com/versatica/mediasoup/actions/runs/9820251862/job/27114630579?pr=1424

@nazar-pc
Copy link
Collaborator

Haven't tinkered with Meson for a while, but if you see unexpected CI issues, their Matrix channel is quite active, worth asking them why things worked in 1.3.1 and do not work in 1.4.1 even though it was supposed to be backwards compatible.

@ibc
Copy link
Member Author

ibc commented Jul 17, 2024

@jmillan, I've updated the PR description with the CI result using all newer versions of Meson. Nothing valuable IMHO. We need to ask Meson devs.

@ibc
Copy link
Member Author

ibc commented Jul 18, 2024

Something I wanna check:

mediasoup-worker.yaml CI runs invoke -r worker test (which always passes) and then it runs invoke -r worker test-asan-address.

Logs in CI (example: https://github.com/versatica/mediasoup/actions/runs/9978006980/job/27573934209?pr=1424) show this:

> Run invoke -r worker test-asan-address

cd "/home/runner/work/mediasoup/mediasoup/worker" && "/home/runner/work/mediasoup/mediasoup/worker/out/pip_meson_ninja/bin/meson" setup --prefix "/home/runner/work/mediasoup/mediasoup/worker/out/Release" --bindir "" --libdir "" --buildtype release -Db_ndebug=true  -Db_sanitize=address -Db_lundef=false "/home/runner/work/mediasoup/mediasoup/worker/out/Release/build"
Directory already configured.

Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
Run "meson setup --reconfigure to force Meson to regenerate.

If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.
cd "/home/runner/work/mediasoup/mediasoup/worker" && "/home/runner/work/mediasoup/mediasoup/worker/out/pip_meson_ninja/bin/meson" setup --prefix "/home/runner/work/mediasoup/mediasoup/worker/out/Release" --bindir "" --libdir "" --buildtype release -Db_ndebug=true  "/home/runner/work/mediasoup/mediasoup/worker/out/Release/build"
Directory already configured.

Is there any chance for source code not being compiled from scratch (so -Db_sanitize=address is not applied somehow) and that makes things fail later when running tests (with ASAN) for whatever inconsistency? Not sure about this since logs below the above ones clearly show that the whole code is compiled (including subprojects).

@ibc
Copy link
Member Author

ibc commented Jul 18, 2024

Surprise coming.

@ibc
Copy link
Member Author

ibc commented Jul 18, 2024

@ibc ibc changed the title Update Meson to 1.4.1 Update Meson to 1.5.0 Jul 18, 2024
@ibc ibc merged commit 1c0121b into v3 Jul 18, 2024
41 checks passed
@ibc ibc deleted the use-meson-1.4.1 branch July 18, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants