Skip to content

Commit

Permalink
Feature/152 update to v6 (#154)
Browse files Browse the repository at this point in the history
* Don't use default 1 for replicaCount

Since `default` handles 0 (zero) as "not set", it's currently impossible to scale the helm chart to 0 replicas.
The default value in the values file is 1 anyways, so this should not cause a breaking change.

* Update Chart.yaml with new version

* Update README.md

* Update Chart.yaml

Switch to v6 image

* Update values.yaml

update documentation comment in values.yaml

---------

Co-authored-by: Juan Picado <[email protected]>
  • Loading branch information
Hechamon and juanpicado authored Oct 3, 2024
1 parent 417e902 commit 4f3542a
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ helm install npm verdaccio/verdaccio

```bash
# Helm v3+
helm install npm --set image.tag=5.29.0 verdaccio/verdaccio
helm install npm --set image.tag=6.0.0 verdaccio/verdaccio
```

### Upgrading Verdaccio
Expand Down
4 changes: 2 additions & 2 deletions charts/verdaccio/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v2
description: A lightweight private node.js proxy registry
name: verdaccio
version: 4.18.0
appVersion: 5.31.1
version: 4.19.0
appVersion: 6.0.0
home: https://verdaccio.org
icon: https://cdn.verdaccio.dev/logos/default.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion charts/verdaccio/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
{{- end }}
spec:
{{- if .Values.replicaCountEnabled }}
replicas: {{ default 1 .Values.replicaCount }}
replicas: {{ .Values.replicaCount }}
{{- end}}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
selector:
Expand Down
2 changes: 1 addition & 1 deletion charts/verdaccio/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image:
repository: verdaccio/verdaccio
# tag: 5.21.1
# tag: defaults to appVersion in Chart.yaml
pullPolicy: IfNotPresent
pullSecrets: []
# - dockerhub-secret
Expand Down

0 comments on commit 4f3542a

Please sign in to comment.