Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(errors): Improve error message for recursive calls. #9650

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Dec 24, 2024

Description

This is a state that you can get into two ways:

  • Genuinely configuring their way into a loop
  • Accidentally misconfiguring their package manager Workspace
    • In some misconfigurations, the Workspace will look like a single-package Workspace, but the previous iteration of our error message didn't give any hints about this.

Either way, we should be providing an informative error message, so this PR provides a message that caters to both situations. We'll need a more verbose explanation, so an error link has been added here, as well.

TODO: Make the page the URL points to.

Testing Instructions

👀 and visit the message page for the URL in the separate repo.

Note

I'd prefer to use Miette's diagnostic and url handling here, but I don't like how it styles the UI. Fixable, but won't do it in this PR...

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:12pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:12pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:12pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:12pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:12pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:12pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:12pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:12pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 4:12pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant