-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(image-optimizer): Add support for AVIF #27432
Closed
+46
−21
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b481d24
chore(fixtures): add test image for avif format
paambaati 0fbb3ab
chore(docs): include references to AVIF wherever relevant
paambaati 9ef9443
feat(image-optimizer): add support for AVIF images if sharp is installed
paambaati 34c5f5e
chore(tests): include tests for AVIF image optimization
paambaati 1ce5502
fix(lint): fix failing lint tests
paambaati fa5de37
fix(tests): Remove unneccessary test case
paambaati a6cedea
fix(image-optimizer): use the correct content-type
paambaati a79103a
fix(test): See if PNGs are converted to AVIFs
paambaati 4f28f6c
fix(fixture): regenerate test AVIF image
paambaati 4cbc1be
fix(tests): Sharp-specific tests.
paambaati a131ffe
fix(tests): fix undefined buffer for AVIF test
paambaati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've just added the support for the case when
sharp
exists in deps, but what about thesquoosh
fallback?in the official squoosh repository, I do see that AVIF is supported ;) should we bring it to Next repo? @styfle @timneutkens wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it will need to be in both. I'm going to update squoosh soon after we get a few bugs fixed