-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AVIF #20381
Closed
Closed
Add support for AVIF #20381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharp v0.27.0 should land tomorrow with support for AVIF (see lovell/sharp#2289 (comment)).
CI is red because the type definitions for |
DefinitelyTyped/DefinitelyTyped#50243 has been merged! Now waiting for the package to be published to npm. |
Changed reference from 'master' to 'main' branch under DPS section in line with GitHub's recent switch from master to main branch as base repo branch names.
Co-authored-by: Luis Alvarez D. <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This makes sure redirects to the index route properly end with a trailing slash or don't based on the `trailingSlash` config to ensure an additional redirect doesn't need to take place un-necessarily. Fixes: #19405
This ensures we show an error for string values for `revalidate` since we currently don't handle these and instead it results in `revalidate: false` being used. This also adds tests for our `revalidate` checks to ensure they are triggered correctly and not triggered for valid values. x-ref: #20310
Upgraded all `http` links to `https` that support the `https` protocol. Llinks ----- - https://github.com/ - https://koajs.com - https://ant.design - https://www.carbondesignsystem.com/components/overview - https://themes.carbondesignsystem.com - https://knexjs.org - https://jxnblk.com/rebass - https://i.imgur.com/JCxtWSj.gif - https://react.semantic-ui.com - https://stomp.github.io - https://videojs.com
Hi ✌️ I've seen that many people have problem with implement Google Tag Manager, I've created an example of how insert "Google Tag Manager" in a NextJs app
I've looked at the example code and saw some consistent issues related to code style. The changes applied to this PR fixes the following points: - Differences of line breaks styles between multiple files - Differences of if statements styles - Unnecessary comment - A typo on a JSDocs --- There were line breaks between statements on `pages/index.js` ```` export async function getServerSideProps(context) { const { client } = await connectToDatabase() const isConnected = await client.isConnected() return { props: { isConnected }, } } ```` And this wasn't being applied to the MongoDB utility: ```` export async function connectToDatabase() { if (cached.conn) return cached.conn if (!cached.promise) { const conn = {} const opts = { useNewUrlParser: true, useUnifiedTopology: true, } {...} ```` And also, as shown in the snippet above, there are different styles of if statements being used. With that being said, the reason I made this PR is because I think that this kind of inconsistent arises questions when a contributor looks to the codebase, even if this is a simple example.
This PR fixes some typos found on examples docs
![image](https://user-images.githubusercontent.com/49720317/103223063-07b23000-4958-11eb-8bf9-09c39231a092.png) About page import wrong pathname causing warning like this.
Change README from outdated @emotion/core to @emotion/react
Co-authored-by: Joe Haddad <[email protected]>
Normally I wouldn't make a PR for a minor version upgrade, but the 2.0.2 version contains some important performance improvements. tailwindlabs/tailwindcss#3032
This makes sure the query isn't dropped when doing a history navigation with i18n. Additional tests have been added to ensure this is working correctly as well. Fixes: #20212
This makes sure we don't generate the wrong locale source variant for the rewrite requiring a `/` on the end which won't ever be added causing the rewrite to never match. Additional tests have been added to ensure this specific rewrite is working correctly. Fixes: #20508
* Docs typo fix * Update docs/basic-features/environment-variables.md Co-authored-by: Lachlan Campbell <[email protected]> Co-authored-by: Joe Haddad <[email protected]> Co-authored-by: Lachlan Campbell <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
**What's the problem this PR addresses?** `@next/mdx` adds the webpack loader `@mdx-js/loader` without resolving it to an absolute path Depends on #17606 **How did you fix it?** `require.resolve` the webpack loader before adding it
As with `const width`, it should be declared just before it is used.
This pull request correctly assigns boolean attributes for `<script />` to match the element as it is created by a server-side render. Prior to this pull request, we'd double-execute `<script>` tags with the `async`, `defer`, or `nomodule` property. --- Fixes #9070
I made the following changes. - Addition of procedure for setting private_key - Addition of procedure for creating a database and setting database_url
Hi, I'm submitting this PR for consideration as a new example app showing Styled JSX with SCSS working inside and outside storybook with example components. Only known issue: I noticed that when running this example with: `$ yarn next ./examples/with-storybook-styled-jsx-scss` I receive the following error: ``` error - ./pages/_app.js Error: [BABEL] .../next.js/examples/with-storybook-styled-jsx-scss/pages/_app.js: Cannot find module 'styled-jsx-plugin-sass' (While processing: ".../next.js/node_modules/next/babel.js") ``` However I notice that this same missing module error is triggered when running this existing example app "with-styled-jsx-scss". Any changes/tweaks needed? Thanks!
https://ant.design/docs/react/getting-started#Import-on-Demand At the document, We don't need to use `babel-import-plugin` to `Import on Demand`.
Closes #19481 The current text implies `query` is a string. IMO it would be better if it clarified that `query` is an object containing the query string's keys and values Edit: Relevant docs url: https://nextjs.org/docs/basic-features/data-fetching#getserversideprops-server-side-rendering
Adds an example using `lru-cache` to implement a simple rate limiter for API routes ([Serverless Functions](https://vercel.com/docs/serverless-functions/introduction)). **Demo: https://nextjs-rate-limit.vercel.app/**
Currently pages with `notFound: false` from `getServerSideProps` behave the same as `notFound: true`, i.e. just having the key is enough to result in a 404. This fixes the check in render.tsx and adds tests for it.
Adds the `pr` section from https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#pr-triggers to filter paths that don't require test runs on PRs.
ijjk
added
create-next-app
Related to our CLI tool for quickly starting a new Next.js application.
examples
Issue/PR related to examples
labels
Jan 5, 2021
Closed
Closing in favor of #20765. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
create-next-app
Related to our CLI tool for quickly starting a new Next.js application.
examples
Issue/PR related to examples
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sharp v0.27.0 should land tomorrow with support for AVIF (see lovell/sharp#2289 (comment)). Lock file can be rebuilt once the release lands.
I generated the
test.avif
file by running thetest.bmp
file through https://squoosh.app/editor