Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ecwid by Lightspeed provider #1304

Merged
merged 3 commits into from
May 7, 2024
Merged

Add Ecwid by Lightspeed provider #1304

merged 3 commits into from
May 7, 2024

Conversation

meteor-ec
Copy link
Contributor

Hi there!

This is Ilnur from the Ecwid by Lightspeed team.

We have added our service as a provider. Please add us to the list.

Thanks a lot!

@vercel Vercel
Copy link

vercel bot commented Feb 27, 2024

@meteor-ec is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

@manovotny
Copy link
Collaborator

Hey @meteor-ec! This is a good start!

I looked at the changes you made and I have some questions.

  1. The checkout page is very slow and the code for the page is interesting. Is this what you expect users to do? Feels like this could be improved.
  2. Why are you adding <link rel="prefetch" href="/api/revalidate" as="fetch" /> to the <head> in the Layout? What are you trying to do or what does this achieve?
  3. image: product.featuredImage?.url in productJsonLd could produce an invalid schema as it could be undefined. It's be better to change the the model to always return a url, and in lib/ecwid return a default images if there isn't a featured image.
  4. The changes to CartModal for not displaying on the checkout page could be improved. Rearranging the structure of your Layouts or using multiple root Layouts would be the better solve here.

@meteor-ec
Copy link
Contributor Author

Hi @manovotny!

Thanks for your review and feedback! I was on vacation and couldn't respond immediately 🌴

So I've made changes to points 2-4, please take a look.

On point 1, we don't have an external url for the checkout page, like Shopify for example. So we embed the checkout into the page. There are plans to improve this place, but for now I decided to leave it as it is.

@manovotny
Copy link
Collaborator

@meteor-ec thanks for making those adjustments.

@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
commerce-shopify ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:31pm

@manovotny manovotny merged commit 42d5d8e into vercel:main May 7, 2024
4 checks passed
@meteor-ec
Copy link
Contributor Author

Thank you so much @manovotny! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotny manovotny manovotny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteor-ec @manovotny