Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (provider/openai-compatible) Additional exports for detailed customization #4166

Closed

Conversation

minpeter
Copy link
Contributor

@minpeter minpeter commented Dec 20, 2024

When creating an external provider using provider/openai-compatible, additional exports are required for detailed customization.

@lgrammel
Copy link
Collaborator

I'm on board with exporting these. However, they should be exported under /internal because they are for providers that extend openai-compatible, and not for end users.

@shaper wdyt? would an /internal dist make sense here and can you help out if so?

@shaper
Copy link
Contributor

shaper commented Dec 20, 2024

I'm on board with exporting these. However, they should be exported under /internal because they are for providers that extend openai-compatible, and not for end users.

@shaper wdyt? would an /internal dist make sense here and can you help out if so?

Sure, @minpeter let me propose an updated PR, I will include you on it as a reviewer. I plan to send it today and will reference this PR as source.

@shaper
Copy link
Contributor

shaper commented Dec 20, 2024

It seems I can't add you as a reviewer but please follow #4179 and comment with any questions. It should be the same as what's here except you'll import from @ai-sdk/openai-compatible/internal.

@shaper shaper closed this Dec 20, 2024
@shaper
Copy link
Contributor

shaper commented Dec 24, 2024

@minpeter thanks for your patience, the change in #4179 includes your commit for tracking purposes and it should be live shortly in v0.0.13 per #4201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants