fix(common): Contract multiple sequential replacers to just one in no…

…rmalizeString (#3289)
vendure-ecommerce · Dec 30, 2024 · f362a4b · f362a4b
1 parent e61abe6
commit f362a4b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/common/src/normalize-string.spec.ts b/packages/common/src/normalize-string.spec.ts
@@ -46,4 +46,11 @@ describe('normalizeString()', () => {
     it('replaces combining diaeresis with e', () => {
         expect(normalizeString('Ja quäkt Schwyz Pöbel vor Gmünd')).toBe('ja quaekt schwyz poebel vor gmuend');
     });
+
+    it('contracts multiple sequential replacers to a single replacer', () => {
+        expect(normalizeString('foo - bar', '-')).toBe('foo-bar');
+        expect(normalizeString('foo--bar', '-')).toBe('foo-bar');
+        expect(normalizeString('foo - bar', '_')).toBe('foo_-_bar');
+        expect(normalizeString('foo _ bar', '_')).toBe('foo_bar');
+    });
 });
diff --git a/packages/common/src/normalize-string.ts b/packages/common/src/normalize-string.ts
@@ -4,6 +4,8 @@
  * Based on https://stackoverflow.com/a/37511463/772859
  */
 export function normalizeString(input: string, spaceReplacer = ' '): string {
+    const multipleSequentialReplacerRegex = new RegExp(`([${spaceReplacer}]){2,}`, 'g');
+
     return (input || '')
         .normalize('NFD')
         .replace(/[\u00df]/g, 'ss')
@@ -12,5 +14,6 @@ export function normalizeString(input: string, spaceReplacer = ' '): string {
         .replace(/[\u0300-\u036f]/g, '')
         .toLowerCase()
         .replace(/[!"£$%^&*()+[\]{};:@#~?\\/,|><`¬'=‘’©®™]/g, '')
-        .replace(/\s+/g, spaceReplacer);
+        .replace(/\s+/g, spaceReplacer)
+        .replace(multipleSequentialReplacerRegex, spaceReplacer);
 }