-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preserve gradientLength when generating discrete gradient color legend #9400
base: main
Are you sure you want to change the base?
fix: preserve gradientLength when generating discrete gradient color legend #9400
Conversation
…to avoid dropping gradientLength
c6fd282
to
c158c80
Compare
Deploying vega-lite with Cloudflare Pages
|
(legendType === 'gradient' && property.startsWith('symbol')) || | ||
(legendType === 'discrete' && property.startsWith('symbol')) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I add any tests or open PRs in vega
, I want to check if this is the behavior (a third legendType called discrete) we want as a public API, or if this was supposed to be a private/internal API.
The discrete legend type was added by @jheer in vega/vega@ddd2bbf , so I'll bring it up as a separate issue in the vega repo vega/vega#3954 .
…erty at compile time
9fe4a63
to
f13f69f
Compare
Motivation
quantile
andquantize
color scales #9399Testing
gradientLength
property should be respected for a color legend that uses quantile, quantize, or threshold scales.300
, and the legend should get taller.Notes
vega-lite
so this PR can be reviewed. However, we could make the diff in this repo smaller if we instead push a change to theLegendType
field inside ofvega
instead.