Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make text formatting preserve invalid values by coercing them to string by default #9353

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented May 20, 2024

PR Description

Checklist

  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully
  • For new features:
    • Has unit tests.
    • Has documentation under site/docs/ + examples.

Tips:

@kanitw kanitw force-pushed the kw/6417-tooltip-null branch from 75907da to 9d67681 Compare May 20, 2024 04:31
Copy link

cloudflare-workers-and-pages bot commented May 20, 2024

Deploying vega-lite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 41f3c37
Status: ✅  Deploy successful!
Preview URL: https://f6042f6a.vega-lite.pages.dev
Branch Preview URL: https://kw-6417-tooltip-null.vega-lite.pages.dev

View logs

@kanitw kanitw force-pushed the kw/6417-tooltip-null branch from 7b5d0b8 to 159bdc1 Compare May 20, 2024 04:41
@kanitw kanitw force-pushed the kw/6417-tooltip-null branch from 159bdc1 to e575e36 Compare May 20, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant