-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new responsive charts and new color settings #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR.
As I understand it, this adds support for responsive charts and changing the colors of bars.
Instead of just setting the fill color in the falcon config, please add support for full Vega configs (https://vega.github.io/vega/docs/config/). This will allow for much greater levels of customization.
To make charts responsive, please add some code to the views to listen to changes of the container size with https://vega.github.io/vega/docs/expressions/#containerSize. This will let Vega handle resizing instead.
I think this support require a lot of effort. You can accept the PR for a minor version. (i.e: 0.14.4) |
Which one? Theming or responsive charts? Does your PR work with charts in multiple columns? It looks like every chart spans the whole width in your video. |
Both. My PR works in multiple columns if you describe your container rewriting utils.ts createElement function and stylish the App.scss. Please see the example and try to change the layout. Then i will be grateful if you approve this PR. |
Following the conversation on issue #144 I have forked the repo and published this feature in a new npm package called shapelets-falcon. I am keeping the links to the main repo and referenced your work. |
Excellent. Thank you for sending the pull request! It's great to see that Falcon is being used and what things would make it better (theming and responsiveness). I'm going to close this PR but I will keep the issues that were inspired by this PR open. |
In this commit you can view a new example of how to use the new config variables fillColor and responsive.