chore(ci): Swap traditional file generator for logrotate_fs for file_to_blackhole test #22285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to_blackhole test The current config fails since limits started being applied to the lading container. We think this is a good time to update to the preferred generator anyway. Signed-off-by: Jesse Szwedko <[email protected]>
jszwedko
added
the
no-changelog
Signed-off-by: Jesse Szwedko <[email protected]>
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.52s Total Time |
pront
approved these changes
Jan 27, 2025
…ing-generator-file-to-blackhole
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jszwedko
deleted the
jszwedko/switch-lading-generator-file-to-blackhole
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current config fails since limits started being applied to the lading container. We think this is a good time to update to the preferred generator anyway.
Change Type
Is this a breaking change?
How did you test this PR?
Will use CI.
Does this PR include user facing changes?
Checklist
make check-allis a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References