Feat/fee logic #969
Draft
Feat/fee logic #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using the optional rlp tag
… not enough maxFee
paologalligit
force-pushed
the
feat/fee-logic
branch
from
59565b5 to
b103881
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/galactica #969 +/- ##
====================================================
Coverage ? 61.18%
====================================================
Files ? 226
Lines ? 24073
Branches ? 0
====================================================
Hits ? 14730
Misses ? 8162
Partials ? 1181 ☔ View full report in Codecov by Sentry. |
otherview
reviewed
Feb 3, 2025
Comment on lines
+66
to
+69
| forkConfig := thor.NoFork | ||
| forkConfig.VIP191 = 1 | ||
| forkConfig.BLOCKLIST = 0 | ||
| forkConfig.VIP214 = 2 |
There was a problem hiding this comment.
Is having VIP24 on block2 something we need to address ?
| @@ -78,9 +84,57 @@ func CalcBaseFee(config *thor.ForkConfig, parent *block.Header) *big.Int { | |||
| y := x.Div(x, parentGasTargetBig) | |||
| baseFeeDelta := x.Div(y, baseFeeChangeDenominator) | |||
|
|
|||
| // Setting the minimun baseFee to InitialBaseFee | |||
There was a problem hiding this comment.
Suggested change
| // Setting the minimun baseFee to InitialBaseFee | |
| // Setting the minimum baseFee to InitialBaseFee |
| ) | ||
| } | ||
| } | ||
|
|
||
| func GalacticaTxGasPriceAdapater(tr *tx.Transaction, gasPrice *big.Int) *GalacticaFeeMarketItems { |
There was a problem hiding this comment.
Suggested change
| func GalacticaTxGasPriceAdapater(tr *tx.Transaction, gasPrice *big.Int) *GalacticaFeeMarketItems { | |
| func GalacticaTxGasPriceAdapter(tr *tx.Transaction, gasPrice *big.Int) *GalacticaFeeMarketItems { |
| @@ -121,6 +124,11 @@ func (p *Packer) Schedule(parent *chain.BlockSummary, nowTimestamp uint64) (flow | |||
| } | |||
| } | |||
|
|
|||
| var baseFee *big.Int | |||
There was a problem hiding this comment.
Would it be worth adding a log saying that we've entered galactica ?
| @@ -113,7 +113,6 @@ func TestP(t *testing.T) { | |||
|
|
|||
| best := repo.BestBlockSummary() | |||
| fmt.Println(best.Header.Number(), best.Header.GasUsed()) | |||
There was a problem hiding this comment.
Might want to change this print to log ?
Comment on lines
+48
to
+52
| if tx.MaxFeePerGas() == nil { | ||
| return nil, errors.New("max fee per gas is required") | ||
| } | ||
| if tx.MaxPriorityFeePerGas() == nil { | ||
| return nil, errors.New("max priority fee per gas is required") |
There was a problem hiding this comment.
This will be set elsewhere, even it its a legacy tx correct ?
Comment on lines
+94
to
+96
| // ErrMaxFeePerGasTooLow is returned if the transaction fee cap is less than the | ||
| // the base fee of the block. | ||
| ErrMaxFeePerGasTooLow = errors.New("max fee per gas is less than block base fee") |
There was a problem hiding this comment.
Suggested change
| // ErrMaxFeePerGasTooLow is returned if the transaction fee cap is less than the | |
| // the base fee of the block. | |
| ErrMaxFeePerGasTooLow = errors.New("max fee per gas is less than block base fee") | |
| // ErrMaxFeePerGasTooLow is returned if the transaction fee cap is less than | |
| // the base fee of the block. | |
| ErrMaxFeePerGasTooLow = errors.New("max fee per gas is less than block base fee") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the logic to calculate the fees dynamically based on the VIP-Dynamic Fee Market.
GHIssue
Type of change
Please delete options that are not relevant.
Checklist: