fix: pedigree edits are not saved (#2112) #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
deps-report 🔍Commit scanned: aa3933f Vulnerable dependencies4 dependencies have vulnerabilities 😱
Outdated dependencies57 outdated dependencies found (including 22 outdated major versions)😢
|
stolpeo
force-pushed
the
2112-pedigree-edits-are-not-saved
branch
from
5b2c670 to
aa3933f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
backend/cases/serializers.py(0 hunks)backend/varfish/tests/drf_openapi_schema/varfish_api_schema.yaml(4 hunks)
💤 Files with no reviewable changes (1)
- backend/cases/serializers.py
| @@ -6072,8 +6072,7 @@ components: | |||
| index: | |||
| type: string | |||
| maxLength: 512 | |||
| pedigree: | |||
| readOnly: true | |||
| pedigree: {} | |||
There was a problem hiding this comment.
Add schema validation and documentation for pedigree field.
The pedigree field is currently defined as an empty object without any schema validation or documentation. This could lead to data integrity issues and make the API harder to use correctly.
Consider:
- Adding a proper schema definition for the pedigree object structure
- Documenting the expected format and required fields
- Adding validation rules to ensure data consistency
Example schema structure:
pedigree:
type: object
description: Pedigree information defining family relationships and affected status
required:
- members
properties:
members:
type: array
items:
type: object
required:
- id
- father
- mother
- sex
- affected
properties:
id:
type: string
father:
type: string
mother:
type: string
sex:
type: string
enum: ['1', '2']
affected:
type: string
enum: ['1', '2']Also applies to: 6155-6175
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
=====================================
Coverage 91% 91%
=====================================
Files 678 678
Lines 38537 38537
=====================================
Hits 35140 35140
Misses 3397 3397
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
presetsetfield is now writable, allowing for more flexible data input.pedigreefield is no longer read-only, enabling updates.Bug Fixes
presetsetfield to handle empty and non-existent values more effectively.Documentation
pedigreeproperty structure and requirements.