chore: switch to ubuntu:noble as base image (#2064) #2065
Conversation
WalkthroughThe changes in this pull request involve updates to the Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
deps-report 🔍Commit scanned: 32ff28f Vulnerable dependencies4 dependencies have vulnerabilities 😱
Outdated dependencies37 outdated dependencies found (including 17 outdated major versions)😢
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
backend/Pipfile.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
- backend/Pipfile (2 hunks)
- utils/docker/Dockerfile (4 hunks)
🔇 Additional comments (6)
backend/Pipfile (1)
112-112: Verify Python version compatibility with dependencies.While broadening the Python version requirement from "3.10" to "3" aligns with the switch to ubuntu:noble (which uses Python 3.12), this change could introduce compatibility issues. Many dependencies in the Pipfile have specific version constraints that might not work across all Python 3.x versions.
Let's verify the compatibility:
Consider either:
- Keeping the specific Python 3.10 requirement if dependencies aren't tested with newer versions
- Explicitly setting it to "3.12" to match ubuntu:noble's Python version
utils/docker/Dockerfile (5)
91-92: Consolidate Installation ofpipenvwith System DependenciesInstalling
pipenvalongside system dependencies improves the build process by reducing layers and potential issues with Python package installations.
145-145: Ensure Compatibility with Updated Worker Image VersionThe worker image has been updated to
0.16.0. Ensure that this version is compatible with your application and that any breaking changes have been addressed.
69-70: Ensure Application Compatibility with Python 3.12The Dockerfile installs Python 3.12 and sets it as the default Python interpreter. Please verify that your application code and dependencies are compatible with Python 3.12, as there may be deprecations or changes affecting your code.
To identify potential compatibility issues, consider running the following script:
#!/bin/bash # Description: Check for deprecated modules and syntax incompatible with Python 3.12. # Search for deprecated syntax (example: usage of `async` and `await` as identifiers). rg '\b(async|await)\b' --include '*.py' # Check for removed modules (example: `asyncio.coroutines` module). rg 'from asyncio import coroutines' --include '*.py'
138-138: Verify Necessity and Availability of New PackagesThe addition of
librocksdb8.9andlibsqlite3-0packages suggests changes in application dependencies. Please confirm that these packages are required and are available in the Ubuntu Noble repositories.You can check the availability of these packages with the following script:
#!/bin/bash # Description: Verify that `librocksdb8.9` and `libsqlite3-0` are available. # Update package lists. apt-get update # Check package availability. apt-cache policy librocksdb8.9 libsqlite3-0
42-42: Ensure Compatibility with Ubuntu NobleThe base image has been changed to
ubuntu:noble. Please verify that all system dependencies and configurations are compatible with this Ubuntu version, as there might be changes in package availability and versions.To check for potential compatibility issues with system packages, you can run the following script:
✅ Verification successful
Ubuntu Noble compatibility verified
Based on the Dockerfile analysis, the system dependencies and configurations are properly handled for Ubuntu Noble:
- The required PostgreSQL 12 repository is correctly configured for Noble
- All essential packages are explicitly installed:
- Core dependencies:
curl,ldap-utils,libldap2-dev,libsasl2-dev- Python stack:
postgresql-client-12,libpq-dev,python3.12,python3-pip- Runtime dependencies:
librocksdb8.9,libsqlite3-0- Proper cleanup of package cache is implemented
- Python environment and alternatives are correctly configured
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that required packages are available in Ubuntu Noble repositories. # Update package lists. apt-get update # Check availability of essential packages. apt-cache policy postgresql-client-12 libpq-dev python3.12 python3-pip librocksdb8.9 libsqlite3-0Length of output: 373
Script:
#!/bin/bash # Let's analyze the Dockerfile to understand the system dependencies and configurations # First, check the Dockerfile content cat utils/docker/Dockerfile # Then, search for any other Dockerfiles in the repository fd Dockerfile # Look for package requirements or dependency files fd -e txt -e ini -e conf -e yaml -e yml -e toml | grep -i "require\|depend\|packages"Length of output: 8174
| @@ -5,7 +5,7 @@ name = "pypi" | |||
|
|
|||
| [packages] | |||
| aldjemy = "~=2.2" | |||
| altamisa = "~=0.2.5" | |||
| altamisa = "~=0.3.0" | |||
There was a problem hiding this comment.
Separate unrelated dependency update.
The altamisa version update from ~=0.2.5 to ~=0.3.0 appears unrelated to the PR's objective of switching the base image. Consider moving this change to a separate PR focused on dependency updates to maintain clear change tracking and easier rollback if needed.
-altamisa = "~=0.3.0"
+altamisa = "~=0.2.5"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| altamisa = "~=0.3.0" | |
| altamisa = "~=0.2.5" |
There was a problem hiding this comment.
This package upgrade is needed because of the broader python version support added in this PR
There was a problem hiding this comment.
@tedil, thank you for the clarification. Understood that the altamisa package upgrade is needed for the broader Python version support added in this PR.
(・ω・)
✏️ Learnings added
Learnt from: tedil
PR: varfish-org/varfish-server#2065
File: backend/Pipfile:8-8
Timestamp: 2024-10-28T12:59:54.233Z
Learning: When updating Python version support to a broader range (e.g., changing `python_version = "3.10"` to `python_version = "3"` in `backend/Pipfile`), the `altamisa` package should be upgraded to `~=0.3.0` to maintain compatibility.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
| RUN wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc \ | ||
| RUN apt-get update && \ | ||
| apt-get install -y wget gnupg2 && \ | ||
| wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc \ |
There was a problem hiding this comment.
Avoid Using Deprecated apt-key Command
The apt-key add command is deprecated and may lead to security issues. It's recommended to use keyrings and the signed-by option in your sources list.
Consider updating the key addition and repository setup as follows:
- wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc \
- | apt-key add - && \
+ wget --quiet -O /usr/share/keyrings/postgresql-archive-keyring.gpg \
+ https://www.postgresql.org/media/keys/ACCC4CF8.asc && \And modify the repository entry:
- echo "deb http://apt.postgresql.org/pub/repos/apt noble-pgdg main" \
- > /etc/apt/sources.list.d/pgdg.list
+ echo "deb [signed-by=/usr/share/keyrings/postgresql-archive-keyring.gpg] \
+ http://apt.postgresql.org/pub/repos/apt noble-pgdg main" \
+ > /etc/apt/sources.list.d/pgdg.listCommittable suggestion was skipped due to low confidence.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
=======================================
Coverage 91% 91%
=======================================
Files 676 677 +1
Lines 38463 39635 +1172
=======================================
+ Hits 35118 36225 +1107
- Misses 3345 3410 +65 |
Summary by CodeRabbit
New Features
Bug Fixes
Chores