Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cancel connection request #439

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Test cancel connection request #439

merged 4 commits into from
Nov 12, 2023

Conversation

fabianfett
Copy link
Collaborator

  • Increase test coverage

@fabianfett fabianfett added semver-patch No public API change. semver-noop No version bump required. and removed semver-patch No public API change. labels Nov 12, 2023
@fabianfett fabianfett requested a review from gwynne November 12, 2023 10:26
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023 •
edited
Loading

Codecov Report

Merging #439 (2760eb1) into main (f0bfba7) will increase coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   59.22%   59.33%   +0.11%     
==========================================
  Files         124      124              
  Lines        9820     9820              
==========================================
+ Hits         5816     5827      +11     
+ Misses       4004     3993      -11

see 5 files with indirect coverage changes

gwynne
gwynne requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only actual change needed is get rid of that stray print(), though wouldn't mind thoughts on the other comments as well.

Tests/ConnectionPoolModuleTests/ConnectionPoolTests.swift Outdated Show resolved Hide resolved
Tests/ConnectionPoolModuleTests/ConnectionPoolTests.swift Show resolved Hide resolved
Tests/ConnectionPoolModuleTests/ConnectionPoolTests.swift Outdated Show resolved Hide resolved
Tests/ConnectionPoolModuleTests/Utils/Waiter.swift Outdated Show resolved Hide resolved
@fabianfett fabianfett merged commit d5d16e3 into vapor:main Nov 12, 2023
12 checks passed
@fabianfett fabianfett added the ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule label Nov 13, 2023
@fabianfett fabianfett added this to the ConnectionPool milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule semver-noop No version bump required.
Projects
None yet
Milestone
ConnectionPool
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @codecov-commenter @gwynne