Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Land ConnectionPool #428

Merged
merged 7 commits into from
Oct 27, 2023
Merged

Land ConnectionPool #428

merged 7 commits into from
Oct 27, 2023

Conversation

fabianfett
Copy link
Collaborator

No description provided.

@fabianfett fabianfett added the semver-patch No public API change. label Oct 26, 2023
@fabianfett fabianfett added this to the ConnectionPool milestone Oct 26, 2023
@fabianfett fabianfett requested a review from gwynne October 26, 2023 09:17
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #428 (9707126) into main (472ff4a) will increase coverage by 1.69%.
The diff coverage is 70.19%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   59.01%   60.70%   +1.69%     
==========================================
  Files         120      121       +1     
  Lines        9188     9480     +292     
==========================================
+ Hits         5422     5755     +333     
+ Misses       3766     3725      -41
Files Coverage Δ
...urces/ConnectionPoolModule/NIOLockedValueBox.swift 100.00% <100.00%> (ø)
...urces/ConnectionPoolModule/ConnectionRequest.swift 62.16% <56.25%> (+2.16%) ⬆️
...ources/ConnectionPoolModule/PoolStateMachine.swift 81.30% <47.05%> (+13.88%) ⬆️
Sources/ConnectionPoolModule/ConnectionPool.swift 75.30% <74.79%> (+75.30%) ⬆️

... and 4 files with indirect coverage changes

@fabianfett fabianfett merged commit 468ae25 into vapor:main Oct 27, 2023
@fabianfett fabianfett deleted the ff-pool-ConnectionPool branch October 27, 2023 06:16
@fabianfett fabianfett added the ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule semver-patch No public API change.
Projects
None yet
Milestone
ConnectionPool
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @codecov-commenter @gwynne