Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConnectionIDGenerator and NoOpKeepAliveBehavior #418

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Add ConnectionIDGenerator and NoOpKeepAliveBehavior #418

merged 2 commits into from
Oct 16, 2023

Conversation

fabianfett
Copy link
Collaborator

No description provided.

@fabianfett fabianfett added the semver-patch No public API change. label Oct 13, 2023
@fabianfett fabianfett added this to the ConnectionPool milestone Oct 13, 2023
@fabianfett fabianfett requested a review from gwynne October 13, 2023 14:59
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@8fbf8ff). Click here to learn what that means.
The diff coverage is 85.71%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #418   +/-   ##
=======================================
  Coverage        ?   55.01%           
=======================================
  Files           ?      110           
  Lines           ?     7904           
  Branches        ?        0           
=======================================
  Hits            ?     4348           
  Misses          ?     3556           
  Partials        ?        0
Files Coverage Δ
...s/ConnectionPoolModule/ConnectionIDGenerator.swift 100.00% <100.00%> (ø)
...ces/ConnectionPoolModule/NoKeepAliveBehavior.swift 66.66% <66.66%> (ø)

@fabianfett fabianfett merged commit 358fa59 into vapor:main Oct 16, 2023
@fabianfett fabianfett deleted the ff-ConnectionIDGenerator branch October 16, 2023 11:20
@fabianfett fabianfett added the ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule semver-patch No public API change.
Projects
None yet
Milestone
ConnectionPool
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @codecov-commenter @gwynne