-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target ConnectionPoolModule
#412
Conversation
We want to land a new ConnectionPool into PostgresNIO in the comming weeks. Since this pool is abstract, let's create a target and product for it. The target and product are both underscored, to signal that we don't make any API stability guarantees.
This change caught my attention. I'm curious, how does this relate to Issue 256? Specifically, does this mean that one or more implementations of a PostgreSQL connection pool will be included with postgres-nio in future? Likewise, will there continue to be support for developers writing their own custom connection pools as is required today? Thanks. |
This PR means work on #256 has started.
Yes we intend to add one implementation directly to PostgresNIO.
We don't intend to break any adopter. However I'd be curious to learn about your use-case... Maybe the new pool is able to fulfill cater to your needs directly? |
Thanks and glad to hear it. We're not doing anything clever. I look forward to transitioning to the connection pool as soon as it's available. Eliminating unnecessary code is always a pleasure. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 49.19% 55.73% +6.54%
==========================================
Files 108 107 -1
Lines 8845 7810 -1035
==========================================
+ Hits 4351 4353 +2
+ Misses 4494 3457 -1037 |
ConnectionPoolModule
ConnectionPoolModule
We want to land a new ConnectionPool into PostgresNIO in the comming weeks. Since this pool is abstract, let's create a target and product for it. The target and product are both underscored, to signal that we don't make any API stability guarantees.