Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify some benchmarks #107

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Simplify some benchmarks #107

merged 1 commit into from
Feb 2, 2025

Conversation

MahdiBM
Copy link
Contributor

@MahdiBM MahdiBM commented Feb 2, 2025

No description provided.

@MahdiBM MahdiBM requested review from 0xTim and gwynne as code owners February 2, 2025 17:50

benchmark.startMeasurement()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use benchmark.startMeasurement() to simplify benchmarks and not have to reserve buffers upfront.

@penny-for-vapor
Copy link

penny-for-vapor bot commented Feb 2, 2025

Benchmark Report

✅ Pull request has no significant performance differences ✅

Click to expand comparison result

Benchmark check running at 2025-02-02 18:00:17 UTC

The baseline '107/merge' is EQUAL to the defined thresholds.

Click to expand benchmark result

Baseline '107/merge'

Host '3edd7752b327' with 2 'aarch64' processors with 3 GB memory, running:
#23-Ubuntu SMP Mon Dec  9 23:51:16 UTC 2024

Parser

CollatingParserAllocations_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) (K) * 82 82 82 82 82 82 82 1

CollatingParserAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 8 8 8 8 8 8 8 1

CollatingParserCPUTime_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 540 551 560 570 580 630 630 20

StreamingParserAllocations_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) (K) * 82 82 82 82 82 82 82 1

StreamingParserAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 6 6 6 6 6 6 6 1

StreamingParserCPUTime_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 520 520 520 530 530 530 530 20

Serializer

100xSerializerCPUTime_1024Parts

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 220 220 220 220 220 220 220 20

SerializerAllocations_1024Parts

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 3087 3087 3087 3087 3087 3087 3087 1

SerializerAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 4 4 4 4 4 4 4 1

@gwynne gwynne added the no-release-needed This PR does not require a release label Feb 2, 2025
@gwynne gwynne merged commit 34ae305 into main Feb 2, 2025
13 checks passed
@gwynne gwynne deleted the mmbm-simplify-benchmark branch February 2, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release-needed This PR does not require a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants