Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up FluentKit tests after SQLKit update #599

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Fix up FluentKit tests after SQLKit update #599

merged 6 commits into from
Apr 15, 2024

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Apr 15, 2024

These changes are now available in 1.47.3

Also bumps Swift minimum to 5.7 and adds ExistentialAny compliance.

@gwynne gwynne added the semver-patch Internal changes only label Apr 15, 2024
@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy April 15, 2024 09:46
@gwynne gwynne enabled auto-merge (squash) April 15, 2024 09:48
@gwynne gwynne disabled auto-merge April 15, 2024 09:52
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 49.25000% with 203 lines in your changes are missing coverage. Please review.

Project coverage is 47.33%. Comparing base (5f0938a) to head (6030a72).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   47.33%   47.33%           
=======================================
  Files         106      106           
  Lines        4758     4758           
=======================================
  Hits         2252     2252           
  Misses       2506     2506           
Files Coverage Δ
Sources/FluentKit/Database/Database.swift 77.77% <100.00%> (ø)
Sources/FluentKit/FluentError.swift 0.00% <ø> (ø)
Sources/FluentKit/Migration/Migration.swift 0.00% <ø> (ø)
Sources/FluentKit/Model/AnyModel.swift 73.07% <100.00%> (ø)
Sources/FluentKit/Model/Fields+Codable.swift 83.87% <100.00%> (ø)
Sources/FluentKit/Model/Fields.swift 97.43% <100.00%> (ø)
Sources/FluentKit/Model/Model.swift 68.75% <100.00%> (ø)
Sources/FluentKit/Properties/CompositeID.swift 88.46% <100.00%> (ø)
Sources/FluentKit/Properties/Property.swift 55.55% <ø> (ø)
Sources/FluentKit/Properties/Relation.swift 51.72% <100.00%> (ø)
... and 59 more

@gwynne gwynne merged commit 81db32f into main Apr 15, 2024
13 of 15 checks passed
@gwynne gwynne deleted the fix-tests branch April 15, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants