Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt swift-wallet and fluent-wallet #19

Merged
merged 22 commits into from
Jan 14, 2025

Conversation

fpseverino
Copy link
Member

This PR implements the first two points of issue #13:

  • Change package name to vapor-community/wallet and target names to VaporWallet, VaporWalletPasses and VaporWalletOrders
  • Use pass and order building offered by swift-wallet
  • Use models and DTOs offered by fluent-wallet

Other changes:

  • Update to VaporTesting
  • Make PersonalizationInfo migration in PassesService optional
  • Improve auth middleware

Closes #13. See the issue for more info and reasons behind the changes.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 97.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.47%. Comparing base (349b450) to head (5ff5fa2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ources/VaporWalletOrders/OrdersServiceCustom.swift 96.55% 1 Missing ⚠️
...ources/VaporWalletPasses/PassesServiceCustom.swift 97.72% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   96.40%   92.47%   -3.93%     
==========================================
  Files          34       10      -24     
  Lines        1167      718     -449     
==========================================
- Hits         1125      664     -461     
- Misses         42       54      +12     
Files with missing lines Coverage Δ
Sources/VaporWallet/Testing/SecretMiddleware.swift 100.00% <ø> (ø)
...rces/VaporWallet/Testing/isLoggingConfigured.swift 100.00% <ø> (ø)
...WalletOrders/Middleware/AppleOrderMiddleware.swift 100.00% <100.00%> (ø)
...iddleware/OrdersService+AsyncModelMiddleware.swift 50.00% <ø> (ø)
Sources/VaporWalletOrders/OrdersService.swift 100.00% <100.00%> (ø)
...rWalletPasses/Middleware/ApplePassMiddleware.swift 100.00% <100.00%> (ø)
...iddleware/PassesService+AsyncModelMiddleware.swift 50.00% <ø> (ø)
Sources/VaporWalletPasses/PassesService.swift 100.00% <100.00%> (ø)
...ources/VaporWalletOrders/OrdersServiceCustom.swift 95.52% <96.55%> (ø)
...ources/VaporWalletPasses/PassesServiceCustom.swift 95.58% <97.72%> (ø)

@fpseverino fpseverino merged commit 900653c into vapor-community:main Jan 14, 2025
11 checks passed
@fpseverino fpseverino deleted the update branch January 14, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Some ideas for the future
2 participants