Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/decision_maker #328

Merged
merged 37 commits into from
Nov 15, 2024
Merged

Conversation

Ravleen-Solulab
Copy link
Contributor

This is the PR for decision_maker_abci.
Covering : states and rounds, dialogues.

@Ravleen-Solulab
Copy link
Contributor Author

This PR contains the test script for the states(14 files), rounds and dialogues of decision_maker_abci.
Update: Everything is completed except the missing coverage in the test_redeem.py.

@@ -3581,4 +3811,4 @@ type = ["pytest-mypy"]
[metadata]
lock-version = "2.0"
python-versions = "<3.12,>=3.8"
content-hash = "d6ff2aadbc8e17ec0cf3d58f0f72d3896302520325f5f69aa2ad78e530b38a96"
content-hash = "43c654a308c15072bda54f5c78ee81e355a9c7172183b4deeb3e61f2728eb6f8"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come so many version updates to the packages here?

assert result == (
synced_data,
Event.MOCK_TX,
) # Should return MOCK_TX since benchmarking is enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these be parametrized?

Copy link
Collaborator

@annasambrook annasambrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, otherwise LGTM

Copy link
Collaborator

@Adamantios Adamantios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some uncovered code in rounds, but we can merge on main and continue from there.

Makefile Outdated Show resolved Hide resolved
# Conflicts:
#	packages/packages.json
#	packages/valory/agents/trader/aea-config.yaml
#	packages/valory/services/trader/service.yaml
#	packages/valory/services/trader_pearl/service.yaml
#	packages/valory/skills/trader_abci/skill.yaml
#	packages/valory/skills/tx_settlement_multiplexer_abci/skill.yaml
@Adamantios Adamantios merged commit e750d12 into valory-xyz:main Nov 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants