Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/conc fsm babydegen #26

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Feat/conc fsm babydegen #26

wants to merge 43 commits into from

Conversation

gauravlochab
Copy link
Collaborator

No description provided.

.gitmodules Outdated
Comment on lines 1 to 6
[submodule "third_party/balpy"]
path = third_party/balpy
url = https://github.com/8ball030/balpy.git
[submodule "third_party/multicaller"]
path = third_party/multicaller
url = https://github.com/8ball030/multicaller.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these needed? It would be preferable to have PyPI released packages with version control

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These packages are dependencies used by the BabyDegen agent. While we could switch to using the PyPI packages, it would require 8baller to release the latest versions, as the most recent releases on PyPI are from 2023.

Copy link
Collaborator Author

@gauravlochab gauravlochab Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE : 8baller will be releasing the updated versions on PyPI, I will integrate those in this merge after that, eliminating the need for the submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants