Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the information regarding cross-period keys #2244

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Adamantios
Copy link
Collaborator

Proposed changes

Update the information regarding cross-period keys

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Adamantios Adamantios added the documentation Improvements or additions to documentation label Jul 2, 2024
@Adamantios Adamantios merged commit 6b406d7 into main Jul 3, 2024
23 checks passed
@Adamantios Adamantios deleted the docs/cross-period branch July 3, 2024 08:22
Adamantios added a commit that referenced this pull request Jul 10, 2024
Revert "fix: crashing when a cross-period persisted key is not set"

This reverts commit 9589609.

Revert "chore: run generators"

This reverts commit 011ed09.

Revert "feat: add method to normalize a value for the db"

This reverts commit 0019700.

Revert "fix: use all the synced data while searching for properties"

This reverts commit b033536.

Revert "test: add test for the `normalize` staticmethod of the db"

This reverts commit e4537b4.

Revert "test: add test for the `_get_synced_value` method of the app"

This reverts commit 7a2db95.

Revert "chore: run generators"

This reverts commit a788246.

Revert "docs: update the information regarding cross-period keys"

This reverts commit 4325e96.

The above commits were introduced in PRs #2236, #2241, #2244.
@Adamantios Adamantios mentioned this pull request Jul 10, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants