Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross period persisted keys #2236

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix cross period persisted keys #2236

merged 2 commits into from
May 31, 2024

Conversation

Adamantios
Copy link
Collaborator

Proposed changes

Do not require the cross-period perstisted keys to be set after period 0.

Fixes

Fixes #2131.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

n/a

@Adamantios Adamantios added the fix label May 30, 2024
@Adamantios Adamantios merged commit 62c4395 into main May 31, 2024
23 checks passed
@Adamantios Adamantios deleted the fix/#2131 branch May 31, 2024 07:58
@Adamantios Adamantios mentioned this pull request Jun 7, 2024
Merged
13 tasks
Adamantios added a commit that referenced this pull request Jul 10, 2024
@Adamantios
fix: revert breaking feature introduced in v0.14.14.post1
e3b75da 
Revert "fix: crashing when a cross-period persisted key is not set"

This reverts commit 9589609.

Revert "chore: run generators"

This reverts commit 011ed09.

Revert "feat: add method to normalize a value for the db"

This reverts commit 0019700.

Revert "fix: use all the synced data while searching for properties"

This reverts commit b033536.

Revert "test: add test for the `normalize` staticmethod of the db"

This reverts commit e4537b4.

Revert "test: add test for the `_get_synced_value` method of the app"

This reverts commit 7a2db95.

Revert "chore: run generators"

This reverts commit a788246.

Revert "docs: update the information regarding cross-period keys"

This reverts commit 4325e96.

The above commits were introduced in PRs #2236, #2241, #2244.
@Adamantios Adamantios mentioned this pull request Jul 10, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angrybayblade angrybayblade angrybayblade approved these changes

@dvilelaf dvilelaf dvilelaf approved these changes

@0xArdi 0xArdi Awaiting requested review from 0xArdi

@jmoreira-valory jmoreira-valory Awaiting requested review from jmoreira-valory

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent crashes when a cross_period_persisted_keys is not set.
3 participants
@Adamantios @dvilelaf @angrybayblade