Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/2203 #2207

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/2203 #2207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed957e0
updated check_unreferenced_events
Devanshusisodiya Mar 28, 2024
3d37d6d
ran linters
Devanshusisodiya Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions autonomy/analyse/abci/app_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,13 +475,14 @@ def check_unreferenced_events(abci_app_cls: Any) -> List[str]:
f"but missing from transition function"
)

# Filter timeout events using referenced events since we don't explicitly return the timeout events
timeout_events = round_transition_events - referenced_events
missing_timeout_events = timeout_events - abci_app_timeout_events
if len(missing_timeout_events) > 0:
# Filter unreferenced events using referenced events since we don't explicitly return the unreferenced events
unreferenced_events = (
round_transition_events - referenced_events
) - abci_app_timeout_events
if len(unreferenced_events) > 0:
error_strings.append(
f"Events {missing_timeout_events} are defined in the round transitions of `{round_cls.__name__}` "
f"but not in `event_to_timeout`"
f"Events {unreferenced_events} are defined in the round transitions of `{round_cls.__name__}` "
f"but not in {round_cls.__name__}"
)

return error_strings
Loading